Skip to content
  • Nadav Amit's avatar
    mm: migrate: fix barriers around tlb_flush_pending · 0a2c4048
    Nadav Amit authored
    Reading tlb_flush_pending while the page-table lock is taken does not
    require a barrier, since the lock/unlock already acts as a barrier.
    Removing the barrier in mm_tlb_flush_pending() to address this issue.
    
    However, migrate_misplaced_transhuge_page() calls mm_tlb_flush_pending()
    while the page-table lock is already released, which may present a
    problem on architectures with weak memory model (PPC).  To deal with
    this case, a new parameter is added to mm_tlb_flush_pending() to
    indicate if it is read without the page-table lock taken, and calling
    smp_mb__after_unlock_lock() in this case.
    
    Link: http://lkml.kernel.org/r/20170802000818.4760-3-namit@vmware.com
    
    
    Signed-off-by: default avatarNadav Amit <namit@vmware.com>
    Acked-by: default avatarRik van Riel <riel@redhat.com>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Mel Gorman <mgorman@suse.de>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jeff Dike <jdike@addtoit.com>
    Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Cc: Mel Gorman <mgorman@techsingularity.net>
    Cc: Nadav Amit <nadav.amit@gmail.com>
    Cc: Russell King <linux@armlinux.org.uk>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    0a2c4048