Skip to content
  • Darrick J. Wong's avatar
    ext4: ext4_fill_super shouldn't return 0 on corruption · 5a9ae68a
    Darrick J. Wong authored
    At the start of ext4_fill_super, ret is set to -EINVAL, and any failure path
    out of that function returns ret.  However, the generic_check_addressable
    clause sets ret = 0 (if it passes), which means that a subsequent failure (e.g.
    a group checksum error) returns 0 even though the mount should fail.  This
    causes vfs_kern_mount in turn to think that the mount succeeded, leading to an
    oops.
    
    A simple fix is to avoid using ret for the generic_check_addressable check,
    which was last changed in commit 30ca22c7
    
    .
    
    Signed-off-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    5a9ae68a