Skip to content
  • Christian Borntraeger's avatar
    KVM: s390: take srcu lock when getting/setting storage keys · 4f899147
    Christian Borntraeger authored
    
    
    The following warning was triggered by missing srcu locks around
    the storage key handling functions.
    
    =============================
    WARNING: suspicious RCU usage
    4.12.0+ #56 Not tainted
    -----------------------------
    ./include/linux/kvm_host.h:572 suspicious rcu_dereference_check() usage!
    rcu_scheduler_active = 2, debug_locks = 1
     1 lock held by live_migration/4936:
      #0:  (&mm->mmap_sem){++++++}, at: [<0000000000141be0>]
    kvm_arch_vm_ioctl+0x6b8/0x22d0
    
     CPU: 8 PID: 4936 Comm: live_migration Not tainted 4.12.0+ #56
     Hardware name: IBM 2964 NC9 704 (LPAR)
     Call Trace:
     ([<000000000011378a>] show_stack+0xea/0xf0)
      [<000000000055cc4c>] dump_stack+0x94/0xd8
      [<000000000012ee70>] gfn_to_memslot+0x1a0/0x1b8
      [<0000000000130b76>] gfn_to_hva+0x2e/0x48
      [<0000000000141c3c>] kvm_arch_vm_ioctl+0x714/0x22d0
      [<000000000013306c>] kvm_vm_ioctl+0x11c/0x7b8
      [<000000000037e2c0>] do_vfs_ioctl+0xa8/0x6c8
      [<000000000037e984>] SyS_ioctl+0xa4/0xb8
      [<00000000008b20a4>] system_call+0xc4/0x27c
     1 lock held by live_migration/4936:
      #0:  (&mm->mmap_sem){++++++}, at: [<0000000000141be0>]
    kvm_arch_vm_ioctl+0x6b8/0x22d0
    
    Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
    Reviewed-by: default avatarPierre <Morel&lt;pmorel@linux.vnet.ibm.com>
    4f899147