Skip to content
  • Peter Zijlstra's avatar
    netdev, sched/wait: Fix sleeping inside wait event · ff960a73
    Peter Zijlstra authored
    
    
    rtnl_lock_unregistering*() take rtnl_lock() -- a mutex -- inside a
    wait loop. The wait loop relies on current->state to function, but so
    does mutex_lock(), nesting them makes for the inner to destroy the
    outer state.
    
    Fix this using the new wait_woken() bits.
    
    Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Cong Wang <cwang@twopensource.com>
    Cc: David Gibson <david@gibson.dropbear.id.au>
    Cc: Eric Biederman <ebiederm@xmission.com>
    Cc: Eric Dumazet <edumazet@google.com>
    Cc: Jamal Hadi Salim <jhs@mojatatu.com>
    Cc: Jerry Chu <hkchu@google.com>
    Cc: Jiri Pirko <jiri@resnulli.us>
    Cc: John Fastabend <john.fastabend@gmail.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
    Cc: sfeldma@cumulusnetworks.com <sfeldma@cumulusnetworks.com>
    Cc: stephen hemminger <stephen@networkplumber.org>
    Cc: Tom Gundersen <teg@jklm.no>
    Cc: Tom Herbert <therbert@google.com>
    Cc: Veaceslav Falico <vfalico@gmail.com>
    Cc: Vlad Yasevich <vyasevic@redhat.com>
    Cc: netdev@vger.kernel.org
    Link: http://lkml.kernel.org/r/20141029173110.GE15602@worktop.programming.kicks-ass.net
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    ff960a73