Commit 1c021bb7 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by David S. Miller

net: fec: only clear a queue's work bit if the queue was emptied

In the receive path a queue's work bit was cleared unconditionally even
if fec_enet_rx_queue only read out a part of the available packets from
the hardware. This resulted in not reading any packets in the next napi
turn and so packets were delayed or lost.

The obvious fix is to only clear a queue's bit when the queue was

Fixes: 4d494cdc ("net: fec: change data structure to support multiqueue")
Signed-off-by: default avatarUwe Kleine-König <>
Reviewed-by: default avatarLucas Stach <>
Tested-by: default avatarFugang Duan <>
Acked-by: default avatarFugang Duan <>
Signed-off-by: default avatarDavid S. Miller <>
parent 20decb7e
......@@ -1521,9 +1521,15 @@ fec_enet_rx(struct net_device *ndev, int budget)
struct fec_enet_private *fep = netdev_priv(ndev);
for_each_set_bit(queue_id, &fep->work_rx, FEC_ENET_MAX_RX_QS) {
clear_bit(queue_id, &fep->work_rx);
pkt_received += fec_enet_rx_queue(ndev,
int ret;
ret = fec_enet_rx_queue(ndev,
budget - pkt_received, queue_id);
if (ret < budget - pkt_received)
clear_bit(queue_id, &fep->work_rx);
pkt_received += ret;
return pkt_received;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment