Commit 2e163414 authored by Julia Lawall's avatar Julia Lawall Committed by Konrad Rzeszutek Wilk

xen-gntalloc: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.
Out_unlock is used on both success and failure, so free vm_priv before
jumping to that label.

A simplified version of the semantic match that finds the problem is as
follows: (

// <smpl>
@r exists@
local idexpression x;
statement S;
identifier f1;
position p1,p2;
expression *ptr != NULL;

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
 return \(0\|<+...x...+>\|ptr\);
 return@p2 ...;

p1 << r.p1;
p2 << r.p2;

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: default avatarJulia Lawall <>
[v1: Altered the description a bit]
Signed-off-by: default avatarKonrad Rzeszutek Wilk <>
parent 01464a60
......@@ -525,6 +525,7 @@ static int gntalloc_mmap(struct file *filp, struct vm_area_struct *vma)
rv = -ENOENT;
pr_debug("%s: Could not find grant reference",
goto out_unlock;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment