Commit 88533f99 authored by Tejun Heo's avatar Tejun Heo Committed by Greg Kroah-Hartman

kernfs: remove unnecessary NULL check in __kernfs_remove()

895a068a ("kernfs: make kernfs_get_active() block if the node is
deactivated but not removed") added "struct kernfs_root *root =
kernfs_root(kn);" at the head of the function; however, the parameter
@kn is checked for later implying that the function may be called with
NULL.  This means that we may end up invoking kernfs_root() with NULL
which will oops.  None of the existing users invokes removal with NULL
@kn, so this bug doesn't actually trigger.

We can relocate kernfs_root() invocation after NULL check; however,
allowing NULL param tends to cause more confusion than actually
helping anything.  As there's no existing user, let's remove the
spurious NULL check.

This bug was detected by smatch.
Signed-off-by: default avatarTejun Heo <>
Reported-by: default avatarDan Carpenter <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 2a41e607
......@@ -920,9 +920,6 @@ static void __kernfs_remove(struct kernfs_node *kn)
if (!kn)
pr_debug("kernfs %s: removing\n", kn->name);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment