Commit e407f39a authored by Michael S. Tsirkin's avatar Michael S. Tsirkin Committed by David S. Miller

vhost: fix performance on LE hosts

commit 2751c988 ("vhost: cross-endian
support for legacy devices") introduced a minor regression: even with
cross-endian disabled, and even on LE host, vhost_is_little_endian is
checking is_le flag so there's always a branch.

To fix, simply check virtio_legacy_is_little_endian first.

Cc: Greg Kurz <>
Signed-off-by: default avatarMichael S. Tsirkin <>
Reviewed-by: default avatarGreg Kurz <>
Signed-off-by: default avatarDavid S. Miller <>
parent 85ff8a43
......@@ -183,10 +183,17 @@ static inline bool vhost_has_feature(struct vhost_virtqueue *vq, int bit)
return vq->acked_features & (1ULL << bit);
static inline bool vhost_is_little_endian(struct vhost_virtqueue *vq)
return vq->is_le;
static inline bool vhost_is_little_endian(struct vhost_virtqueue *vq)
return virtio_legacy_is_little_endian() || vq->is_le;
/* Memory accessors */
static inline u16 vhost16_to_cpu(struct vhost_virtqueue *vq, __virtio16 val)
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment