Commit f182df2e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

drm/amdgpu: Potential uninitialized variable in amdgpu_vm_update_directories()

commit 78aa02c7 upstream.

After commit ea09729c ("drm/amdgpu: rework page directory filling
v2") then it becomes a lot harder to verify that "r" is initialized.  My
static checker complains and so I've reviewed the code.  It does look
like it might be buggy... Anyway, it doesn't hurt to set "r" to zero
at the start.
Reviewed-by: default avatarChristian König <>
Signed-off-by: default avatarDan Carpenter <>
Signed-off-by: default avatarAlex Deucher <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 2d8b3a9b
......@@ -1201,7 +1201,7 @@ static void amdgpu_vm_invalidate_level(struct amdgpu_vm_pt *parent)
int amdgpu_vm_update_directories(struct amdgpu_device *adev,
struct amdgpu_vm *vm)
int r;
int r = 0;
r = amdgpu_vm_update_level(adev, vm, &vm->root, 0);
if (r)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment