1. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      How this work was done:
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
      All documentation files were explicitly excluded.
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
         For non */uapi/* files that summary was:
         SPDX license identifier                            # files
         GPL-2.0                                              11139
         and resulted in the first patch in this series.
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                        930
         and resulted in the second patch in this series.
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
         and that resulted in the third patch in this series.
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  2. 11 Oct, 2017 1 commit
  3. 10 Oct, 2017 2 commits
    • Arnd Bergmann's avatar
      remoteproc: qcom: fix RPMSG_QCOM_GLINK_SMEM dependencies · ab759b97
      Arnd Bergmann authored
      When RPMSG_QCOM_GLINK_SMEM=m and one driver causes the qcom_common.c file
      to be compiled as built-in, we get a link error:
      drivers/remoteproc/qcom_common.o: In function `glink_subdev_remove':
      qcom_common.c:(.text+0x130): undefined reference to `qcom_glink_smem_unregister'
      qcom_common.c:(.text+0x130): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `qcom_glink_smem_unregister'
      drivers/remoteproc/qcom_common.o: In function `glink_subdev_probe':
      qcom_common.c:(.text+0x160): undefined reference to `qcom_glink_smem_register'
      qcom_common.c:(.text+0x160): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `qcom_glink_smem_register'
      Out of the three PIL driver instances, QCOM_ADSP_PIL already has a
      Kconfig dependency to prevent this from happening, but the other two
      do not. This adds the same dependency there.
      Fixes: eea07023 ("remoteproc: qcom: adsp: Allow defining GLINK edge")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    • Dan Carpenter's avatar
      remoteproc: imx_rproc: fix a couple off by one bugs · 68c2d645
      Dan Carpenter authored
      The priv->mem[] array has IMX7D_RPROC_MEM_MAX elements so the > should
      be >= to avoid writing one element beyond the end of the array.
      Fixes: a0ff4aa6 ("remoteproc: imx_rproc: add a NXP/Freescale imx_rproc driver")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
  4. 01 Sep, 2017 3 commits
  5. 30 Aug, 2017 2 commits
  6. 29 Aug, 2017 1 commit
  7. 28 Aug, 2017 3 commits
  8. 24 Aug, 2017 5 commits
  9. 02 Aug, 2017 1 commit
    • Bjorn Andersson's avatar
      remoteproc: qcom: Add support for SSR notifications · 1e140df0
      Bjorn Andersson authored
      This adds the remoteproc part of subsystem restart, which is responsible
      for emitting notifications to other processors in the system about a
      dying remoteproc instance.
      These notifications are propagated to the various communication systems
      in the various remote processors to shut down communication links that
      was left in a dangling state as the remoteproc was stopped (or crashed).
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
  10. 26 Jul, 2017 1 commit
  11. 27 Jun, 2017 3 commits
  12. 26 Jun, 2017 2 commits
    • Andrew F. Davis's avatar
      remoteproc/keystone: Ensure the DSPs are in reset in probe · 11d2a2ff
      Andrew F. Davis authored
      The DSPs are expected to be in reset when the driver probes a device.
      If the DSPs are out of reset in probe, the system may crash when the
      firmware is being loaded. So, add a check to make sure the DSP resets
      are asserted, and if not, throw a eye-catchy warning and assert the
      resets specifically.
      Signed-off-by: default avatarAndrew F. Davis <afd@ti.com>
      [s-anna@ti.com: replace warning with a WARN]
      Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
      Acked-by: default avatarSantosh Shilimkar <ssantosh@kernel.org>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    • Suman Anna's avatar
      remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs · e88bb8f7
      Suman Anna authored
      The Texas Instrument's Keystone 2 family of SoCs has 1 or more
      TMS320C66x DSP Core Subsystems (C66x CorePacs). Each subsystem has
      a C66x Fixed/Floating-Point DSP Core, with 32KB of L1P and L1D SRAMs,
      that can be configured and partitioned as either RAM and/or Cache,
      and 1 MB of L2 SRAM. The CorePac also includes an Internal DMA (IDMA),
      External Memory Controller (EMC), Extended Memory Controller (XMC)
      with a Memory Protection and Address Extension (MPAX) unit, a Bandwidth
      Management (BWM) unit, an Interrupt Controller (INTC) and a Powerdown
      Controller (PDC).
      A new remoteproc module is added to perform the device management of
      these DSP devices. The driver expects the firmware names to be of the
      form "keystone-dsp<X>-fw", where X is the corresponding DSP number, and
      uses the standard remoteproc core ELF loader. The support is limited
      to images only using the DSP internal memories at the moment. This
      remoteproc driver is also designed to work with virtio, and uses the
      IPC Generation registers for performing the virtio signalling and
      getting notified of exceptions.
      The driver currently supports the 66AK2H/66AK2K, 66AK2L and 66AK2E
      Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
      Signed-off-by: default avatarSam Nelson <sam.nelson@ti.com>
      Signed-off-by: default avatarAndrew F. Davis <afd@ti.com>
      Acked-by: default avatarSantosh Shilimkar <ssantosh@kernel.org>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
  13. 25 Jun, 2017 3 commits
    • Suman Anna's avatar
      remoteproc/davinci: fix unbalanced reset between start and stop ops · a63c70d4
      Suman Anna authored
      The davinci remoteproc driver is currently de-asserting the reset in
      its rproc .start() ops, but is not asserting the reset in its .stop()
      ops. This leaves the remote processor to not boot properly when using
      the sysfs 'state' variable between multiple start and stop operations.
      On the other hand, a reset is being asserted unconditionally in the
      driver remove function to alleviate some of these issues.
      Move this reset assertion logic into the .stop() ops implementation
      to fix the sysfs state-machine and the unbalanced reset. The logic
      from remove is still effective since .stop() ops will be invoked
      during the remove due to the enabled 'auto-boot' support. The probe
      already has support for asserting the reset in case the DSP is not
      in reset for some reason.
      Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    • Suman Anna's avatar
      remoteproc/davinci: simplify the reset function · 470ac62f
      Suman Anna authored
      The reset_assert() function is used to make sure the DSP remote
      processor is in a reset state regardless of its previous state.
      The driver relies on davinci_clk_reset_{assert,deassert}()
      functions for reset management which take in a clock parameter.
      The assert_reset() performs a clk_get()/clk_put() cycle to
      acquire the clock handle to use with this function. This is
      totally unnecessary and the code can be simplified to use
      the clock acquired during probe and directly use the reset
      functions, so simplify this logic.
      Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    • Suman Anna's avatar
      remoteproc/davinci: Update Kconfig to depend on DMA_CMA · c51e882c
      Suman Anna authored
      The davinci remoteproc driver requires a CMA pool for allocating
      memory for virtio vrings/buffers and other sections of the firmware
      image. The allocations are done using the DMA API. The CMA option is
      currently selected automatically on systems with MMU when davinci
      remoteproc is enabled, switch this to a saner depends on dependency
      convention. The dependency is also updated to use the DMA_CMA kconfig
      symbol that is used for CMA allocations using the DMA API, the CMA
      dependency is inherited implicitly.
      Cc: Arnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
  14. 31 May, 2017 1 commit
  15. 27 May, 2017 2 commits
  16. 02 May, 2017 1 commit
  17. 29 Mar, 2017 1 commit
  18. 20 Mar, 2017 1 commit
    • Arnd Bergmann's avatar
      remoteproc: qcom: fix QCOM_SMD dependencies · c3104aae
      Arnd Bergmann authored
      qcom_smd_register_edge() is provided by either QCOM_SMD or RPMSG_QCOM_SMD,
      and if both of them are disabled, it does nothing.
      The check for the PIL drivers however only checks for QCOM_SMD, so it breaks
      with QCOM_SMD=n && RPMSG_QCOM_SMD=m:
      drivers/remoteproc/built-in.o: In function `smd_subdev_remove':
      qcom_wcnss_iris.c:(.text+0x231c): undefined reference to `qcom_smd_unregister_edge'
      drivers/remoteproc/built-in.o: In function `smd_subdev_probe':
      qcom_wcnss_iris.c:(.text+0x2344): undefined reference to `qcom_smd_register_edge'
      drivers/remoteproc/built-in.o: In function `smd_subdev_probe':
      qcom_q6v5_pil.c:(.text+0x3538): undefined reference to `qcom_smd_register_edge'
      qcom_q6v5_pil.c:(.text+0x3538): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `qcom_smd_register_edge'
      This clarifies the Kconfig dependency.
      Fixes: 4b48921a ("remoteproc: qcom: Use common SMD edge handler")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
  19. 27 Feb, 2017 1 commit
  20. 22 Feb, 2017 1 commit
  21. 06 Feb, 2017 4 commits