Skip to content
  • Joe Perches's avatar
    checkpatch: whine about ACCESS_ONCE · 481aea5c
    Joe Perches authored
    
    
    Add a test for use of ACCESS_ONCE that could be written using READ_ONCE or
    WRITE_ONCE.
    
    --fix it too if desired.
    
    The WRITE_ONCE fixes are less correct than the coccinelle script below as
    checkpatch cannot have a completely correct "expression" mechanism because
    checkpatch works on patches and not complete files.
    
    $ cat access_once.cocci
    @@
    expression e1;
    expression e2;
    @@
    
    -       ACCESS_ONCE(e1) = e2
    +       WRITE_ONCE(e1, e2)
    
    @@
    expression e1;
    @@
    
    -       ACCESS_ONCE(e1)
    +       READ_ONCE(e1)
    
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Cc: Julia Lawall <julia.lawall@lip6.fr>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    481aea5c