Skip to content
  • Sergey Senozhatsky's avatar
    of: do not leak console options · db179e0d
    Sergey Senozhatsky authored
    
    
    Do not strdup() console options. It seems that the only reason for
    it to be strdup()-ed was a compilation warning: printk, UART and
    console drivers, for some reason, expect char pointer instead of
    const char pointer. So we can just pass `of_stdout_options', but
    need to cast it to char pointer. A better fix would be to change
    printk, console drivers and UART to accept const char `options';
    but that will take time - there are lots of drivers to update.
    
    The patch also fixes a possible memory leak: add_preferred_console()
    can fail, but we don't kfree() options.
    
    Signed-off-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
    Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
    Signed-off-by: default avatarRob Herring <robh@kernel.org>
    db179e0d