• Laurent Pinchart's avatar
    drm/fsl-dcu: Don't set connector DPMS property · e685410c
    Laurent Pinchart authored
    commit daee5426 upstream.
    Since commit 4a97a3da ("drm: Don't update property values for atomic
    drivers") atomic drivers must not update property values as properties
    are read from the state instead. To catch remaining users, the
    drm_object_property_set_value() function now throws a warning when
    called by atomic drivers on non-immutable properties, and we hit that
    warning when creating connectors.
    The easy fix is to just remove the drm_object_property_set_value() as it
    is used here to set the initial value of the connector's DPMS property
    to OFF. The DPMS property applies on top of the connector's state crtc
    pointer (initialized to NULL) that is the main connector on/off control,
    and should thus default to ON.
    Fixes: 4a97a3da ("drm: Don't update property values for atomic drivers")
    Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
fsl_dcu_drm_rgb.c 4.28 KB