Commit adf305f7 authored by Javi Merino's avatar Javi Merino Committed by Greg Kroah-Hartman

sysfs: fix warning when creating a sysfs group without attributes

When attempting to create a gropu without attrs, the warning prints the
name of the group.  However, the check for name being a NULL pointer is
wrong: it uses the pointer to the name when it's NULL.  Fix it to use
the name if present, otherwise just put an empty string.

Cc: Bruno Prémont <>
Cc: Greg Kroah-Hartman <>
Signed-off-by: default avatarJavi Merino <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 68ff2a00
......@@ -99,7 +99,7 @@ static int internal_create_group(struct kobject *kobj, int update,
return -EINVAL;
if (!grp->attrs && !grp->bin_attrs) {
WARN(1, "sysfs: (bin_)attrs not set by subsystem for group: %s/%s\n",
kobj->name, grp->name ? "" : grp->name);
kobj->name, grp->name ?: "");
return -EINVAL;
if (grp->name) {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment