Commit d5e06a18 authored by Linus Torvalds's avatar Linus Torvalds Committed by Greg Kroah-Hartman

loop: fix concurrent lo_open/lo_release

commit ae665016 upstream.

范龙飞 reports that KASAN can report a use-after-free in __lock_acquire.
The reason is due to insufficient serialization in lo_release(), which
will continue to use the loop device even after it has decremented the
lo_refcnt to zero.

In the meantime, another process can come in, open the loop device
again as it is being shut down. Confusion ensues.
Reported-by: default avatar范龙飞 <>
Signed-off-by: default avatarLinus Torvalds <>
Signed-off-by: default avatarJens Axboe <>
Cc: Ben Hutchings <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent d383a427
......@@ -1576,9 +1576,8 @@ static int lo_open(struct block_device *bdev, fmode_t mode)
return err;
static void lo_release(struct gendisk *disk, fmode_t mode)
static void __lo_release(struct loop_device *lo)
struct loop_device *lo = disk->private_data;
int err;
if (atomic_dec_return(&lo->lo_refcnt))
......@@ -1605,6 +1604,13 @@ static void lo_release(struct gendisk *disk, fmode_t mode)
static void lo_release(struct gendisk *disk, fmode_t mode)
static const struct block_device_operations lo_fops = {
.owner = THIS_MODULE,
.open = lo_open,
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment