Commit f41ced8f authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Linus Torvalds

Check fops_get() return value

Several subsystem open handlers dereference the fops_get() return value
without checking it for nullness.  This opens a race condition between the
open handler and module unloading.

A module can be marked as being unloaded (MODULE_STATE_GOING) before its
exit function is called and gets the chance to unregister the driver.
During that window open handlers can still be called, and fops_get() will
fail in try_module_get() and return a NULL pointer.

This change checks the fops_get() return value and returns -ENODEV if NULL.
Reported-by: default avatarAlan Jenkins <>
Signed-off-by: default avatarLaurent Pinchart <>
Acked-by: default avatarTakashi Iwai <>
Cc: Al Viro <>
Cc: Dave Airlie <>
Acked-by: default avatarMauro Carvalho Chehab <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent bdbeed75
......@@ -183,6 +183,10 @@ int drm_stub_open(struct inode *inode, struct file *filp)
old_fops = filp->f_op;
filp->f_op = fops_get(&dev->driver->fops);
if (filp->f_op == NULL) {
filp->f_op = old_fops;
goto out;
if (filp->f_op->open && (err = filp->f_op->open(inode, filp))) {
filp->f_op = fops_get(old_fops);
......@@ -79,6 +79,10 @@ static int dvb_device_open(struct inode *inode, struct file *file)
file->private_data = dvbdev;
old_fops = file->f_op;
file->f_op = fops_get(dvbdev->fops);
if (file->f_op == NULL) {
file->f_op = old_fops;
goto fail;
err = file->f_op->open(inode,file);
if (err) {
......@@ -90,6 +94,7 @@ static int dvb_device_open(struct inode *inode, struct file *file)
return err;
return -ENODEV;
......@@ -152,6 +152,10 @@ static int __snd_open(struct inode *inode, struct file *file)
old_fops = file->f_op;
file->f_op = fops_get(mptr->f_ops);
if (file->f_op == NULL) {
file->f_op = old_fops;
return -ENODEV;
if (file->f_op->open)
err = file->f_op->open(inode, file);
if (err) {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment