1. 13 Jul, 2017 3 commits
  2. 15 May, 2017 3 commits
  3. 29 Nov, 2016 1 commit
    • Chuck Lever's avatar
      SUNRPC: Proper metric accounting when RPC is not transmitted · ae09531d
      Chuck Lever authored
      I noticed recently that during an xfstests on a krb5i mount, the
      retransmit count for certain operations had gone negative, and the
      backlog value became unreasonably large. I recall that Andy has
      pointed this out to me in the past.
      
      When call_refresh fails to find a valid credential for an RPC, the
      RPC exits immediately without sending anything on the wire. This
      leaves rq_ntrans, rq_xtime, and rq_rtt set to zero.
      
      The solution for om_queue is to not add the to RPC's running backlog
      queue total whenever rq_xtime is zero.
      
      For om_ntrans, it's a bit more difficult. A zero rq_ntrans causes
      om_ops to become larger than om_ntrans. The design of the RPC
      metrics API assumes that ntrans will always be equal to or larger
      than the ops count. The result is that when an RPC fails to find
      credentials, the RPC operation's reported retransmit count, which is
      computed in user space as the difference between ops and ntrans,
      goes negative.
      
      Ideally the kernel API should report a separate retransmit and
      "exited before initial transmission" metric, so that user space can
      sort out the difference properly.
      
      To avoid kernel API changes and changes to the way rq_ntrans is used
      when performing transport locking, account for untransmitted RPCs
      so that om_ntrans keeps up with om_ops: always add one or more to
      om_ntrans.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
      ae09531d
  4. 03 Feb, 2015 1 commit
  5. 25 Nov, 2014 1 commit
    • Chuck Lever's avatar
      SUNRPC: serialize iostats updates · edef1297
      Chuck Lever authored
      Occasionally mountstats reports a negative retransmission rate.
      Ensure that two RPCs completing concurrently don't confuse the sums
      in the transport's op_metrics array.
      
      Since pNFS filelayout can invoke rpc_count_iostats() on another
      transport from xprt_release(), we can't rely on simply holding the
      transport_lock in xprt_release(). There's nothing for it but hard
      serialization. One spin lock per RPC operation should make this as
      painless as it can be.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
      edef1297
  6. 30 Aug, 2013 1 commit
  7. 09 Apr, 2013 1 commit
    • Al Viro's avatar
      procfs: new helper - PDE_DATA(inode) · d9dda78b
      Al Viro authored
      The only part of proc_dir_entry the code outside of fs/proc
      really cares about is PDE(inode)->data.  Provide a helper
      for that; static inline for now, eventually will be moved
      to fs/proc, along with the knowledge of struct proc_dir_entry
      layout.
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      d9dda78b
  8. 02 Mar, 2012 1 commit
  9. 17 Feb, 2012 1 commit
  10. 01 Feb, 2012 2 commits
  11. 16 Nov, 2010 1 commit
  12. 27 Sep, 2010 1 commit
  13. 14 May, 2010 2 commits
    • Trond Myklebust's avatar
      SUNRPC: Move the task->tk_bytes_sent and tk_rtt to struct rpc_rqst · d60dbb20
      Trond Myklebust authored
      It seems strange to maintain stats for bytes_sent in one structure, and
      bytes received in another. Try to assemble all the RPC request-related
      stats in struct rpc_rqst
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      d60dbb20
    • Chuck Lever's avatar
      SUNRPC: Replace jiffies-based metrics with ktime-based metrics · ff839970
      Chuck Lever authored
      Currently RPC performance metrics that tabulate elapsed time use
      jiffies time values.  This is problematic on systems that use slow
      jiffies (for instance 100HZ systems built for paravirtualized
      environments).  It is also a problem for computing precise latency
      statistics for advanced network transports, such as InfiniBand,
      that can have round-trip latencies significanly faster than a single
      clock tick.
      
      For the RPC client, adopt the high resolution time stamp mechanism
      already used by the network layer and blktrace: ktime.
      
      We use ktime format time stamps for all internal computations, and
      convert to milliseconds for presentation.  As a result, we need only
      addition operations in the performance critical paths; multiply/divide
      is required only for presentation.
      
      We could report RTT metrics in microseconds.  In fact the mountstats
      format is versioned to accomodate exactly this kind of interface
      improvement.
      
      For now, however, we'll stay with millisecond precision for
      presentation to maintain backwards compatibility with the handful of
      currently deployed user space tools.  At a later point, we'll move to
      an API such as BDI_STATS where a finer timestamp precision can be
      reported.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      ff839970
  14. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  15. 17 Jun, 2009 2 commits
    • Ricardo Labiaga's avatar
      nfs41: Rename rq_received to rq_reply_bytes_recvd · dd2b63d0
      Ricardo Labiaga authored
      The 'rq_received' member of 'struct rpc_rqst' is used to track when we
      have received a reply to our request.  With v4.1, the backchannel
      can now accept callback requests over the existing connection.  Rename
      this field to make it clear that it is only used for tracking reply bytes
      and not all bytes received on the connection.
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      dd2b63d0
    • Ricardo Labiaga's avatar
      nfs41: Add backchannel processing support to RPC state machine · 55ae1aab
      Ricardo Labiaga authored
      Adds rpc_run_bc_task() which is called by the NFS callback service to
      process backchannel requests.  It performs similar work to rpc_run_task()
      though "schedules" the backchannel task to be executed starting at the
      call_trasmit state in the RPC state machine.
      
      It also introduces some miscellaneous updates to the argument validation,
      call_transmit, and transport cleanup functions to take into account
      that there are now forechannel and backchannel tasks.
      
      Backchannel requests do not carry an RPC message structure, since the
      payload has already been XDR encoded using the existing NFSv4 callback
      mechanism.
      
      Introduce a new transmit state for the client to reply on to backchannel
      requests.  This new state simply reserves the transport and issues the
      reply.  In case of a connection related error, disconnects the transport and
      drops the reply.  It requires the forechannel to re-establish the connection
      and the server to retransmit the request, as stated in NFSv4.1 section
      2.9.2 "Client and Server Transport Behavior".
      
      Note: There is no need to loop attempting to reserve the transport.  If EAGAIN
      is returned by xprt_prepare_transmit(), return with tk_status == 0,
      setting tk_action to call_bc_transmit.  rpc_execute() will invoke it again
      after the task is taken off the sleep queue.
      
      [nfs41: rpc_run_bc_task() need not be exported outside RPC module]
      [nfs41: New call_bc_transmit RPC state]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      [nfs41: Backchannel: No need to loop in call_bc_transmit()]
      Signed-off-by: default avatarAndy Adamson <andros@netapp.com>
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      [rpc_count_iostats incorrectly exits early]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      [Convert rpc_reply_expected() to inline function]
      [Remove unnecessary BUG_ON()]
      [Rename variable]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      55ae1aab
  16. 30 Mar, 2009 1 commit
    • Alexey Dobriyan's avatar
      proc 2/2: remove struct proc_dir_entry::owner · 99b76233
      Alexey Dobriyan authored
      Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
      as correctly noted at bug #12454. Someone can lookup entry with NULL
      ->owner, thus not pinning enything, and release it later resulting
      in module refcount underflow.
      
      We can keep ->owner and supply it at registration time like ->proc_fops
      and ->data.
      
      But this leaves ->owner as easy-manipulative field (just one C assignment)
      and somebody will forget to unpin previous/pin current module when
      switching ->owner. ->proc_fops is declared as "const" which should give
      some thoughts.
      
      ->read_proc/->write_proc were just fixed to not require ->owner for
      protection.
      
      rmmod'ed directories will be empty and return "." and ".." -- no harm.
      And directories with tricky enough readdir and lookup shouldn't be modular.
      We definitely don't want such modular code.
      
      Removing ->owner will also make PDE smaller.
      
      So, let's nuke it.
      
      Kudos to Jeff Layton for reminding about this, let's say, oversight.
      
      http://bugzilla.kernel.org/show_bug.cgi?id=12454Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      99b76233
  17. 07 Jan, 2009 1 commit
  18. 02 May, 2008 1 commit
  19. 28 Feb, 2008 1 commit
  20. 01 Feb, 2008 2 commits
  21. 30 Jan, 2008 2 commits
  22. 10 Oct, 2007 1 commit
    • Eric W. Biederman's avatar
      [NET]: Make /proc/net per network namespace · 457c4cbc
      Eric W. Biederman authored
      This patch makes /proc/net per network namespace.  It modifies the global
      variables proc_net and proc_net_stat to be per network namespace.
      The proc_net file helpers are modified to take a network namespace argument,
      and all of their callers are fixed to pass &init_net for that argument.
      This ensures that all of the /proc/net files are only visible and
      usable in the initial network namespace until the code behind them
      has been updated to be handle multiple network namespaces.
      
      Making /proc/net per namespace is necessary as at least some files
      in /proc/net depend upon the set of network devices which is per
      network namespace, and even more files in /proc/net have contents
      that are relevant to a single network namespace.
      Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      457c4cbc
  23. 14 Feb, 2007 1 commit
    • Tim Schmielau's avatar
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau authored
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: default avatarTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cd354f1a
  24. 12 Feb, 2007 1 commit
  25. 03 Feb, 2007 1 commit
  26. 21 Jul, 2006 1 commit
  27. 19 Apr, 2006 1 commit
  28. 28 Mar, 2006 1 commit
  29. 20 Mar, 2006 3 commits