1. 18 Oct, 2018 7 commits
  2. 10 Oct, 2018 1 commit
  3. 04 Oct, 2018 3 commits
  4. 29 Sep, 2018 12 commits
  5. 26 Sep, 2018 6 commits
  6. 19 Sep, 2018 1 commit
    • Takashi Iwai's avatar
      ALSA: hda - Fix cancel_work_sync() stall from jackpoll work · cc427108
      Takashi Iwai authored
      commit 16037643969e095509cd8446a3f8e406a6dc3a2c upstream.
      
      On AMD/ATI controllers, the HD-audio controller driver allows a bus
      reset upon the error recovery, and its procedure includes the
      cancellation of pending jack polling work as found in
      snd_hda_bus_codec_reset().  This works usually fine, but it becomes a
      problem when the reset happens from the jack poll work itself; then
      calling cancel_work_sync() from the work being processed tries to wait
      the finish endlessly.
      
      As a workaround, this patch adds the check of current_work() and
      applies the cancel_work_sync() only when it's not from the
      jackpoll_work.
      
      This doesn't fix the root cause of the reported error below, but at
      least, it eases the unexpected stall of the whole system.
      
      Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200937
      Cc: <stable@vger.kernel.org>
      Cc: Lukas Wunner <lukas@wunner.de>
      Signed-off-by: 's avatarTakashi Iwai <tiwai@suse.de>
      Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      cc427108
  7. 15 Sep, 2018 2 commits
  8. 05 Sep, 2018 3 commits
  9. 24 Aug, 2018 1 commit
    • Takashi Iwai's avatar
      ALSA: seq: Fix UBSAN warning at SNDRV_SEQ_IOCTL_QUERY_NEXT_CLIENT ioctl · b171162c
      Takashi Iwai authored
      [ Upstream commit c9a4c63888dbb79ce4d068ca1dd8b05bc3f156b1 ]
      
      The kernel may spew a WARNING with UBSAN undefined behavior at
      handling ALSA sequencer ioctl SNDRV_SEQ_IOCTL_QUERY_NEXT_CLIENT:
      
      UBSAN: Undefined behaviour in sound/core/seq/seq_clientmgr.c:2007:14
      signed integer overflow:
      2147483647 + 1 cannot be represented in type 'int'
      Call Trace:
       __dump_stack lib/dump_stack.c:77 [inline]
       dump_stack+0x122/0x1c8 lib/dump_stack.c:113
       ubsan_epilogue+0x12/0x86 lib/ubsan.c:159
       handle_overflow+0x1c2/0x21f lib/ubsan.c:190
        __ubsan_handle_add_overflow+0x2a/0x31 lib/ubsan.c:198
       snd_seq_ioctl_query_next_client+0x1ac/0x1d0 sound/core/seq/seq_clientmgr.c:2007
       snd_seq_ioctl+0x264/0x3d0 sound/core/seq/seq_clientmgr.c:2144
       ....
      
      It happens only when INT_MAX is passed there, as we're incrementing it
      unconditionally.  So the fix is trivial, check the value with
      INT_MAX.  Although the bug itself is fairly harmless, it's better to
      fix it so that fuzzers won't hit this again later.
      
      Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200211Signed-off-by: 's avatarTakashi Iwai <tiwai@suse.de>
      Signed-off-by: 's avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b171162c
  10. 22 Aug, 2018 4 commits