• Marc Zyngier's avatar
    genirq: Track whether the trigger type has been set · c01dd3ad
    Marc Zyngier authored
    commit 4f8413a3 upstream.
    
    When requesting a shared interrupt, we assume that the firmware
    support code (DT or ACPI) has called irqd_set_trigger_type
    already, so that we can retrieve it and check that the requester
    is being reasonnable.
    
    Unfortunately, we still have non-DT, non-ACPI systems around,
    and these guys won't call irqd_set_trigger_type before requesting
    the interrupt. The consequence is that we fail the request that
    would have worked before.
    
    We can either chase all these use cases (boring), or address it
    in core code (easier). Let's have a per-irq_desc flag that
    indicates whether irqd_set_trigger_type has been called, and
    let's just check it when checking for a shared interrupt.
    If it hasn't been set, just take whatever the interrupt
    requester asks.
    
    Fixes: 382bd4de ("genirq: Use irqd_get_trigger_type to compare the trigger type for shared IRQs")
    Reported-and-tested-by: default avatarPetr Cvek <petrcvekcz@gmail.com>
    Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c01dd3ad
Name
Last commit
Last update
..
Kconfig Loading commit data...
Makefile Loading commit data...
affinity.c Loading commit data...
autoprobe.c Loading commit data...
chip.c Loading commit data...
cpuhotplug.c Loading commit data...
debug.h Loading commit data...
debugfs.c Loading commit data...
devres.c Loading commit data...
dummychip.c Loading commit data...
generic-chip.c Loading commit data...
handle.c Loading commit data...
internals.h Loading commit data...
ipi.c Loading commit data...
irq_sim.c Loading commit data...
irqdesc.c Loading commit data...
irqdomain.c Loading commit data...
manage.c Loading commit data...
migration.c Loading commit data...
msi.c Loading commit data...
pm.c Loading commit data...
proc.c Loading commit data...
resend.c Loading commit data...
settings.h Loading commit data...
spurious.c Loading commit data...
timings.c Loading commit data...