Commit 3dc6ddfe authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Bjorn Helgaas

PCI: faraday: Add missing of_node_put()

The call to of_get_next_child() returns a node pointer with refcount
incremented thus it must be explicitly decremented here in the error
path and after the last usage.

Fixes: d3c68e0a ("PCI: faraday: Add Faraday Technology FTPCI100 PCI Host Bridge driver")
Signed-off-by: default avatarNicholas Mc Guire <>
[ updated commit log]
Signed-off-by: default avatarLorenzo Pieralisi <>
Signed-off-by: default avatarBjorn Helgaas <>
Reviewed-by: default avatarLinus Walleij <>
parent 342639d9
......@@ -355,11 +355,13 @@ static int faraday_pci_setup_cascaded_irq(struct faraday_pci *p)
irq = of_irq_get(intc, 0);
if (irq <= 0) {
dev_err(p->dev, "failed to get parent IRQ\n");
return irq ?: -EINVAL;
p->irqdomain = irq_domain_add_linear(intc, PCI_NUM_INTX,
&faraday_pci_irqdomain_ops, p);
if (!p->irqdomain) {
dev_err(p->dev, "failed to create Gemini PCI IRQ domain\n");
return -EINVAL;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment