Commit 39b4954c authored by Liu Bo's avatar Liu Bo Committed by Shaohua Li

badblocks: fix wrong return value in badblocks_set if badblocks are disabled

MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if
badblocks are disabled, otherwise, rdev_set_badblocks() will record
superblock changes and return success in that case and md will fail to
report an IO error which it should.

This bug has existed since badblocks were introduced in commit
9e0e252a ("badblocks: Add core badblock management code").
Signed-off-by: default avatarLiu Bo <>
Acked-by: default avatarGuoqing Jiang <>
Signed-off-by: default avatarShaohua Li <>
parent b90f6ff0
......@@ -178,7 +178,7 @@ int badblocks_set(struct badblocks *bb, sector_t s, int sectors,
if (bb->shift < 0)
/* badblocks are disabled */
return 0;
return 1;
if (bb->shift) {
/* round the start down, and the end up */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment