Commit 9a4864c8 authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Walleij

gpio: tb10x: fix return value check in tb10x_gpio_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR(). Also remove the dev_err call to avoid redundant
error message.
Signed-off-by: default avatarWei Yongjun <>
Signed-off-by: default avatarLinus Walleij <>
parent 85aa3915
......@@ -207,10 +207,8 @@ static int tb10x_gpio_probe(struct platform_device *pdev)
tb10x_gpio->base = devm_ioremap_resource(&pdev->dev, mem);
if (!tb10x_gpio->base) {
dev_err(&pdev->dev, "Could not remap reg space.\n");
goto fail_ioremap;
if (IS_ERR(tb10x_gpio->base))
return PTR_ERR(tb10x_gpio->base);
tb10x_gpio->gc.label = of_node_full_name(dn);
tb10x_gpio-> = &pdev->dev;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment