1. 27 Dec, 2015 2 commits
  2. 23 Nov, 2015 1 commit
    • Peter Robinson's avatar
      watchdog: omap_wdt: fix null pointer dereference · de55acd1
      Peter Robinson authored
      Fix issue from two patches overlapping causing a kernel oops
      
      [ 3569.297449] Unable to handle kernel NULL pointer dereference at virtual address 00000088
      [ 3569.306272] pgd = dc894000
      [ 3569.309287] [00000088] *pgd=00000000
      [ 3569.313104] Internal error: Oops: 5 [#1] SMP ARM
      [ 3569.317986] Modules linked in: ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ebtable_filter ebtable_nat ebtable_broute bridge stp llc ebtables ip6table_security ip6table_raw ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_filter ip6_tables iptable_security iptable_raw iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle musb_dsps cppi41 musb_hdrc phy_am335x udc_core phy_generic phy_am335x_control omap_sham omap_aes omap_rng omap_hwspinlock omap_mailbox hwspinlock_core musb_am335x omap_wdt at24 8250_omap leds_gpio cpufreq_dt smsc davinci_mdio mmc_block ti_cpsw cpsw_common ptp pps_core cpsw_ale davinci_cpdma omap_hsmmc omap_dma mmc_core i2c_dev
      [ 3569.386293] CPU: 0 PID: 1429 Comm: wdctl Not tainted 4.3.0-0.rc7.git0.1.fc24.armv7hl #1
      [ 3569.394740] Hardware name: Generic AM33XX (Flattened Device Tree)
      [ 3569.401179] task: dbd11a00 ti: dbaac000 task.ti: dbaac000
      [ 3569.406917] PC is at omap_wdt_get_timeleft+0xc/0x20 [omap_wdt]
      [ 3569.413106] LR is at watchdog_ioctl+0x3cc/0x42c
      [ 3569.417902] pc : [<bf0ab138>]    lr : [<c0739c54>]    psr: 600f0013
      [ 3569.417902] sp : dbaadf18  ip : 00000003  fp : 7f5d3bbe
      [ 3569.430014] r10: 00000000  r9 : 00000003  r8 : bef21ab8
      [ 3569.435535] r7 : dbbc0f7c  r6 : dbbc0f18  r5 : bef21ab8  r4 : 00000000
      [ 3569.442427] r3 : 00000000  r2 : 00000000  r1 : 8004570a  r0 : dbbc0f18
      [ 3569.449323] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
      [ 3569.456858] Control: 10c5387d  Table: 9c894019  DAC: 00000051
      [ 3569.462927] Process wdctl (pid: 1429, stack limit = 0xdbaac220)
      [ 3569.469179] Stack: (0xdbaadf18 to 0xdbaae000)
      [ 3569.473790] df00:                                                       bef21ab8 dbf60e38
      [ 3569.482441] df20: dc91b840 8004570a bef21ab8 c03988a4 dbaadf48 dc854000 00000000 dd313850
      [ 3569.491092] df40: ddf033b8 0000570a dc91b80b dbaadf3c dbf60e38 00000020 c0df9250 c0df6c48
      [ 3569.499741] df60: dc91b840 8004570a 00000000 dc91b840 dc91b840 8004570a bef21ab8 00000003
      [ 3569.508389] df80: 00000000 c03989d4 bef21b74 7f5d3bad 00000003 00000036 c020fcc4 dbaac000
      [ 3569.517037] dfa0: 00000000 c020fb00 bef21b74 7f5d3bad 00000003 8004570a bef21ab8 00000001
      [ 3569.525685] dfc0: bef21b74 7f5d3bad 00000003 00000036 00000001 00000000 7f5e4eb0 7f5d3bbe
      [ 3569.534334] dfe0: 7f5e4f10 bef21a3c 7f5d0a54 b6e97e0c a00f0010 00000003 00000000 00000000
      [ 3569.543038] [<bf0ab138>] (omap_wdt_get_timeleft [omap_wdt]) from [<c0739c54>] (watchdog_ioctl+0x3cc/0x42c)
      [ 3569.553266] [<c0739c54>] (watchdog_ioctl) from [<c03988a4>] (do_vfs_ioctl+0x5bc/0x698)
      [ 3569.561648] [<c03988a4>] (do_vfs_ioctl) from [<c03989d4>] (SyS_ioctl+0x54/0x7c)
      [ 3569.569400] [<c03989d4>] (SyS_ioctl) from [<c020fb00>] (ret_fast_syscall+0x0/0x3c)
      [ 3569.577413] Code: e12fff1e e52de004 e8bd4000 e5903060 (e5933088)
      [ 3569.584089] ---[ end trace cec3039bd3ae610a ]---
      
      Cc: <stable@vger.kernel.org> # v4.2+
      Signed-off-by: default avatarPeter Robinson <pbrobinson@gmail.com>
      Acked-by: default avatarLars Poeschel <poeschel@lemonage.de>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      de55acd1
  3. 09 Sep, 2015 1 commit
  4. 01 Jul, 2015 1 commit
  5. 22 Jun, 2015 5 commits
  6. 17 Feb, 2015 1 commit
  7. 20 Oct, 2014 1 commit
  8. 31 Mar, 2014 2 commits
  9. 17 Nov, 2013 2 commits
  10. 01 Mar, 2013 1 commit
  11. 02 Jan, 2013 1 commit
  12. 19 Dec, 2012 4 commits
  13. 30 Nov, 2012 1 commit
  14. 28 Nov, 2012 3 commits
  15. 08 Nov, 2012 1 commit
    • Paul Walmsley's avatar
      watchdog: OMAP: use standard GETBOOTSTATUS interface; use platform_data fn ptr · 129f5577
      Paul Walmsley authored
      Previously the OMAP watchdog driver used a non-standard way to report
      the chip reset source via the GETBOOTSTATUS ioctl.  This patch
      converts the driver to use the standard WDIOF_* flags for this
      purpose.
      
      This patch may break existing userspace code that uses the existing
      non-standard data format returned by the OMAP watchdog driver's
      GETBOOTSTATUS ioctl.  To fetch detailed reset source information,
      userspace code will need to retrieve it directly from the CGRM or PRM
      drivers when those are completed.
      
      Previously, to fetch the reset source, the driver either read a
      register outside the watchdog IP block (OMAP1), or called a function
      exported directly from arch/arm/mach-omap2.  Both approaches are
      broken.  This patch also converts the driver to use a platform_data
      function pointer.  This approach is temporary, and is due to the lack
      of drivers for the OMAP16xx+ Clock Generation and Reset Management IP
      block and the OMAP2+ Power and Reset Management IP block.  Once
      drivers are available for those IP blocks, the watchdog driver can be
      converted to call exported functions from those drivers directly.
      At that point, the platform_data function pointer can be removed.
      
      In the short term, this patch is needed to allow the PRM code to be
      removed from arch/arm/mach-omap2 (it is being moved to a driver).
      
      This version integrates a fix from Jon Hunter <jon-hunter@ti.com>
      that avoids a NULL pointer dereference in a DT-only boot, and integrates
      a patch commit message fix from Felipe Balbi <balbi@ti.com>.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      Cc: Wim Van Sebroeck <wim@iguana.be>
      Acked-by: default avatarWim Van Sebroeck <wim@iguana.be>
      [paul@pwsan.com: integrated pdata fix from Jon Hunter]
      Cc: Jon Hunter <jon-hunter@ti.com>
      [paul@pwsan.com: integrated changelog fix from Felipe Balbi]
      Cc: Felipe Balbi <balbi@ti.com>
      129f5577
  16. 13 Sep, 2012 1 commit
    • Tony Lindgren's avatar
      ARM: OMAP: Split plat/hardware.h, use local soc.h for omap2+ · dbc04161
      Tony Lindgren authored
      As the plat and mach includes need to disappear for single zImage work,
      we need to remove plat/hardware.h.
      
      Do this by splitting plat/hardware.h into omap1 and omap2+ specific files.
      
      The old plat/hardware.h already has omap1 only defines, so it gets moved
      to mach/hardware.h for omap1. For omap2+, we use the local soc.h
      that for now just includes the related SoC headers to keep this patch more
      readable.
      
      Note that the local soc.h still includes plat/cpu.h that can be dealt
      with in later patches. Let's also include plat/serial.h from common.h for
      all the board-*.c files. This allows making the include files local later
      on without patching these files again.
      
      Note that only minimal changes are done in this patch for the
      drivers/watchdog/omap_wdt.c driver to keep things compiling. Further
      patches are needed to eventually remove cpu_is_omap usage in the drivers.
      
      Also only minimal changes are done to sound/soc/omap/* to remove the
      unneeded includes and to define OMAP44XX_MCPDM_L3_BASE locally so there's
      no need to include omap44xx.h.
      
      While at it, also sort some of the includes in the standard way.
      
      Cc: linux-watchdog@vger.kernel.org
      Cc: alsa-devel@alsa-project.org
      Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
      Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
      Cc: Liam Girdwood <lrg@ti.com>
      Acked-by: default avatarWim Van Sebroeck <wim@iguana.be>
      Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      dbc04161
  17. 23 Jul, 2012 1 commit
    • Lokesh Vutla's avatar
      Watchdog: OMAP: Fix the runtime pm code to avoid module getting stuck intransition state. · 41814eed
      Lokesh Vutla authored
      OMAP watchdog driver is adapted to runtime PM like a general device
      driver but it is not appropriate. It is causing couple of functional
      issues.
      
      1. On OMAP4 SYSCLK can't be gated, because of issue with WDTIMER2 module,
      which constantly stays in "in transition" state. Value of register
      CM_WKUP_WDTIMER2_CLKCTRL is always 0x00010000 in this case.
      Issue occurs immediately after first idle, when hwmod framework tries
      to disable WDTIMER2 functional clock - "wd_timer2_fck". After this
      module falls to "in transition" state, and SYSCLK gating is blocked.
      
      2. Due to runtime PM, watchdog timer may be completely disabled.
      In current code base watchdog timer is not disabled only because of
      issue 1. Otherwise state of WDTIMER2 module will be "Disabled", and there
      will be no interrupts from omap_wdt. In other words watchdog will not
      work at all.
      
      Watchdong is a special IP and it should not be disabled otherwise
      purpose of it itself is defeated. Watchdog functional clock should
      never be disabled. This patch updates the runtime PM handling in
      driver so that runtime PM is limited only during probe/shutdown
      and suspend/resume.
      
      The patch fixes issue 1 and 2
      Signed-off-by: Lokesh Vutla's avatarLokesh Vutla <lokeshvutla@ti.com>
      Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      41814eed
  18. 09 Jul, 2012 1 commit
  19. 27 Mar, 2012 1 commit
  20. 27 Jan, 2012 1 commit
  21. 06 Jan, 2012 3 commits
    • Shubhrajyoti D's avatar
      watchdog: omap_wdt.c: fix the WDIOC_GETBOOTSTATUS ioctl if not implemented. · e2bf7c4c
      Shubhrajyoti D authored
      WDIOC_GETBOOTSTATUS ioctl is imlemented for cpu_is_omap16xx and cpu_is_omap24xx
      cpus only. For other cpus it falls through to WDIOC_KEEPALIVE.
      This patch prevents the fall through.
      
      Cc: sricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarShubhrajyoti D <shubhrajyoti@ti.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      e2bf7c4c
    • Axel Lin's avatar
      watchdog: convert drivers/watchdog/* to use module_platform_driver() · b8ec6118
      Axel Lin authored
      This patch converts the drivers in drivers/watchdog/* to use the
      module_platform_driver() macro which makes the code smaller and a bit
      simpler.
      Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
      Cc: Nicolas Thill <nico@openwrt.org>
      Cc: Florian Fainelli <florian@openwrt.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Paul Cercueil <paul@crapouillou.net>
      Cc: Marc Zyngier <maz@misterjones.org>
      Cc: Wan ZongShun <mcuos.com@gmail.com>
      Cc: Alejandro Cabrera <aldaya@gmail.com>
      Cc: "George G. Davis" <gdavis@mvista.com>
      Cc: Sylver Bruneau <sylver.bruneau@googlemail.com>
      Cc: Vitaly Wool <vital@embeddedalley.com>
      Cc: Mika Westerberg <mika.westerberg@iki.fi>
      Cc: Timo Kokkonen <timo.t.kokkonen@nokia.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      b8ec6118
    • Axel Lin's avatar
      watchdog: Use DEFINE_SPINLOCK() for static spinlocks · 1334f329
      Axel Lin authored
      Rather than just defining static spinlock_t variables and then
      initializing them later in init functions, simply define them with
      DEFINE_SPINLOCK() and remove the calls to spin_lock_init().
      Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
      Cc: Nicolas Thill <nico@openwrt.org>
      Cc: Heiko Ronsdorf <hero@ihg.uni-duisburg.de>
      Cc: Rodolfo Giometti <giometti@ascensit.com>
      Cc: Andrey Panin <pazke@donpac.ru>
      Cc: Guido Guenther <agx@sigxcpu.org>
      Cc: Curt E Bruns <curt.e.bruns@intel.com>
      Cc: Deepak Saxena <dsaxena@plexity.net>
      Cc: Andrew Victor <linux@maxim.org.za>
      Cc: George G. Davis <gdavis@mvista.com>
      Cc: Sylver Bruneau <sylver.bruneau@googlemail.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      1334f329
  22. 11 Mar, 2011 1 commit
  23. 15 Oct, 2010 1 commit
    • Arnd Bergmann's avatar
      llseek: automatically add .llseek fop · 6038f373
      Arnd Bergmann authored
      All file_operations should get a .llseek operation so we can make
      nonseekable_open the default for future file operations without a
      .llseek pointer.
      
      The three cases that we can automatically detect are no_llseek, seq_lseek
      and default_llseek. For cases where we can we can automatically prove that
      the file offset is always ignored, we use noop_llseek, which maintains
      the current behavior of not returning an error from a seek.
      
      New drivers should normally not use noop_llseek but instead use no_llseek
      and call nonseekable_open at open time.  Existing drivers can be converted
      to do the same when the maintainer knows for certain that no user code
      relies on calling seek on the device file.
      
      The generated code is often incorrectly indented and right now contains
      comments that clarify for each added line why a specific variant was
      chosen. In the version that gets submitted upstream, the comments will
      be gone and I will manually fix the indentation, because there does not
      seem to be a way to do that using coccinelle.
      
      Some amount of new code is currently sitting in linux-next that should get
      the same modifications, which I will do at the end of the merge window.
      
      Many thanks to Julia Lawall for helping me learn to write a semantic
      patch that does all this.
      
      ===== begin semantic patch =====
      // This adds an llseek= method to all file operations,
      // as a preparation for making no_llseek the default.
      //
      // The rules are
      // - use no_llseek explicitly if we do nonseekable_open
      // - use seq_lseek for sequential files
      // - use default_llseek if we know we access f_pos
      // - use noop_llseek if we know we don't access f_pos,
      //   but we still want to allow users to call lseek
      //
      @ open1 exists @
      identifier nested_open;
      @@
      nested_open(...)
      {
      <+...
      nonseekable_open(...)
      ...+>
      }
      
      @ open exists@
      identifier open_f;
      identifier i, f;
      identifier open1.nested_open;
      @@
      int open_f(struct inode *i, struct file *f)
      {
      <+...
      (
      nonseekable_open(...)
      |
      nested_open(...)
      )
      ...+>
      }
      
      @ read disable optional_qualifier exists @
      identifier read_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      expression E;
      identifier func;
      @@
      ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off)
      {
      <+...
      (
         *off = E
      |
         *off += E
      |
         func(..., off, ...)
      |
         E = *off
      )
      ...+>
      }
      
      @ read_no_fpos disable optional_qualifier exists @
      identifier read_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      @@
      ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off)
      {
      ... when != off
      }
      
      @ write @
      identifier write_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      expression E;
      identifier func;
      @@
      ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off)
      {
      <+...
      (
        *off = E
      |
        *off += E
      |
        func(..., off, ...)
      |
        E = *off
      )
      ...+>
      }
      
      @ write_no_fpos @
      identifier write_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      @@
      ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off)
      {
      ... when != off
      }
      
      @ fops0 @
      identifier fops;
      @@
      struct file_operations fops = {
       ...
      };
      
      @ has_llseek depends on fops0 @
      identifier fops0.fops;
      identifier llseek_f;
      @@
      struct file_operations fops = {
      ...
       .llseek = llseek_f,
      ...
      };
      
      @ has_read depends on fops0 @
      identifier fops0.fops;
      identifier read_f;
      @@
      struct file_operations fops = {
      ...
       .read = read_f,
      ...
      };
      
      @ has_write depends on fops0 @
      identifier fops0.fops;
      identifier write_f;
      @@
      struct file_operations fops = {
      ...
       .write = write_f,
      ...
      };
      
      @ has_open depends on fops0 @
      identifier fops0.fops;
      identifier open_f;
      @@
      struct file_operations fops = {
      ...
       .open = open_f,
      ...
      };
      
      // use no_llseek if we call nonseekable_open
      ////////////////////////////////////////////
      @ nonseekable1 depends on !has_llseek && has_open @
      identifier fops0.fops;
      identifier nso ~= "nonseekable_open";
      @@
      struct file_operations fops = {
      ...  .open = nso, ...
      +.llseek = no_llseek, /* nonseekable */
      };
      
      @ nonseekable2 depends on !has_llseek @
      identifier fops0.fops;
      identifier open.open_f;
      @@
      struct file_operations fops = {
      ...  .open = open_f, ...
      +.llseek = no_llseek, /* open uses nonseekable */
      };
      
      // use seq_lseek for sequential files
      /////////////////////////////////////
      @ seq depends on !has_llseek @
      identifier fops0.fops;
      identifier sr ~= "seq_read";
      @@
      struct file_operations fops = {
      ...  .read = sr, ...
      +.llseek = seq_lseek, /* we have seq_read */
      };
      
      // use default_llseek if there is a readdir
      ///////////////////////////////////////////
      @ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier readdir_e;
      @@
      // any other fop is used that changes pos
      struct file_operations fops = {
      ... .readdir = readdir_e, ...
      +.llseek = default_llseek, /* readdir is present */
      };
      
      // use default_llseek if at least one of read/write touches f_pos
      /////////////////////////////////////////////////////////////////
      @ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier read.read_f;
      @@
      // read fops use offset
      struct file_operations fops = {
      ... .read = read_f, ...
      +.llseek = default_llseek, /* read accesses f_pos */
      };
      
      @ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier write.write_f;
      @@
      // write fops use offset
      struct file_operations fops = {
      ... .write = write_f, ...
      +	.llseek = default_llseek, /* write accesses f_pos */
      };
      
      // Use noop_llseek if neither read nor write accesses f_pos
      ///////////////////////////////////////////////////////////
      
      @ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier read_no_fpos.read_f;
      identifier write_no_fpos.write_f;
      @@
      // write fops use offset
      struct file_operations fops = {
      ...
       .write = write_f,
       .read = read_f,
      ...
      +.llseek = noop_llseek, /* read and write both use no f_pos */
      };
      
      @ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier write_no_fpos.write_f;
      @@
      struct file_operations fops = {
      ... .write = write_f, ...
      +.llseek = noop_llseek, /* write uses no f_pos */
      };
      
      @ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier read_no_fpos.read_f;
      @@
      struct file_operations fops = {
      ... .read = read_f, ...
      +.llseek = noop_llseek, /* read uses no f_pos */
      };
      
      @ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      @@
      struct file_operations fops = {
      ...
      +.llseek = noop_llseek, /* no read or write fn */
      };
      ===== End semantic patch =====
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Cc: Julia Lawall <julia@diku.dk>
      Cc: Christoph Hellwig <hch@infradead.org>
      6038f373
  24. 29 Sep, 2010 1 commit
  25. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  26. 23 Dec, 2009 1 commit