1. 24 Feb, 2009 1 commit
    • Roel Kluin's avatar
      i2c: Timeouts reach -1 · a746b578
      Roel Kluin authored
      With a postfix decrement these timeouts reach -1 rather than 0, but
      after the loop it is tested whether they have become 0.
      As pointed out by Jean Delvare, the condition we are waiting for should
      also be tested before the timeout. With the current order, you could
      exit with a timeout error while the job is actually done.
      Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
  2. 26 Jan, 2009 1 commit
  3. 14 Jul, 2008 3 commits
    • Jean Delvare's avatar
      i2c: Check for ACPI resource conflicts · 54fb4a05
      Jean Delvare authored
      Check for ACPI resource conflicts in i2c bus drivers. I've included
      all recent SMBus master drivers for PC hardware.
      I've voluntarily left out:
      * Drivers that don't run on PCs: they can't conflict with ACPI.
      * Bit-banged bus device drivers: it's very unlikely that ACPI would
        deal with such buses.
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
    • Jean Delvare's avatar
      i2c: Let bus drivers add SPD to their class · 3401b2ff
      Jean Delvare authored
      Let general purpose I2C/SMBus bus drivers add SPD to their class. Once
      this is done, we will be able to tell the eeprom driver to only probe
      for SPD EEPROMs and similar on these buses.
      Note that I took a conservative approach here, adding I2C_CLASS_SPD to
      many drivers that have no idea whether they can host SPD EEPROMs or not.
      This is to make sure that the eeprom driver doesn't stop probing buses
      where SPD EEPROMs or equivalent live.
      So, bus driver maintainers and users should feel free to remove the SPD
      class from drivers those buses never have SPD EEPROMs or they don't
      want the eeprom driver to bind to them. Likewise, feel free to add the
      SPD class to any bus driver I might have missed.
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    • David Brownell's avatar
      i2c: Bus drivers return -Errno not -1 · 97140342
      David Brownell authored
      Tighten error paths used by various i2c adapters (mostly x86) so
      they return real fault/errno codes instead of a "-1" (which is
      most often interpreted as "-EPERM").  Build tested, with eyeball
      One minor initial goal is to have adapters consistently return
      the code "-ENXIO" when addressing a device doesn't get an ACK
      response, at least in the probe paths where they are already
      good at stifling related logspam.
      Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
  4. 13 Oct, 2007 1 commit
  5. 01 May, 2007 1 commit
    • David Brownell's avatar
      i2c: Shrink struct i2c_client · 2096b956
      David Brownell authored
      This shrinks the size of "struct i2c_client" by 40 bytes:
       - Substantially shrinks the string used to identify the chip type
       - The "flags" don't need to be so big
       - Removes some internal padding
      It also adds kerneldoc for that struct, explaining how "name" is really a
      chip type identifier; it's otherwise potentially confusing.
      Because the I2C_NAME_SIZE symbol was abused for both i2c_client.name
      and for i2c_adapter.name, this needed to affect i2c_adapter too.  The
      adapters which used that symbol now use the more-obviously-correct
      idiom of taking the size of that field.
      JD: Shorten i2c_adapter.name from 50 to 48 bytes while we're here, to
      avoid wasting space in padding.
      Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
  6. 22 Mar, 2007 1 commit
  7. 17 Feb, 2007 1 commit
  8. 14 Feb, 2007 1 commit
    • Tim Schmielau's avatar
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau authored
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: default avatarTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
  9. 13 Feb, 2007 2 commits
    • Jean Delvare's avatar
      i2c-amd8111: Proposed cleanups · 88b9e750
      Jean Delvare authored
      Proposed cleanups to the i2c-amd8111 SMBus driver:
      * Fold long lines.
      * Add an explicit mask when writing the low byte of a word.
      * Use I2C_SMBUS_BLOCK_MAX instead of hardcoding 32.
      * Discard extra blank lines.
      * Use boolean not instead of bitwise not for bit tests, it's clearer.
      * Return -EBUSY rather than -1 on I/O resource conflict.
      * Fix a race on device registration, initialization should be done
        before the bus is registered.
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    • Stephen Hemminger's avatar
      i2c: Add IDs to adapters · 9ace555d
      Stephen Hemminger authored
      IDs have been defined but not used by most of the I2C adapters.
      By having a unique ID, clients can check for correct connection
      during probe.
      Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
  10. 26 Sep, 2006 1 commit
  11. 11 Nov, 2005 1 commit
  12. 28 Oct, 2005 5 commits
  13. 05 Sep, 2005 2 commits
  14. 22 Jun, 2005 1 commit
  15. 16 Apr, 2005 1 commit
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      Let it rip!