1. 04 May, 2015 2 commits
    • Suman Anna's avatar
      bus: omap_l3_noc: Fix master id address decoding for OMAP5 · e7309c26
      Suman Anna authored
      The L3 Error handling on OMAP5 for the most part is very similar
      to that of OMAP4, and had leveraged common data structures and
      register layout definitions so far. Upon closer inspection, there
      are a few minor differences causing an incorrect decoding and
      reporting of the master NIU upon an error:
      
        1. The L3_TARG_STDERRLOG_MSTADDR.STDERRLOG_MSTADDR occupies
           11 bits on OMAP5 as against 8 bits on OMAP4, with the master
           NIU connID encoded in the 6 MSBs of the STDERRLOG_MSTADDR
           field.
        2. The CLK3 FlagMux component has 1 input source on OMAP4 and 3
           input sources on OMAP5. The common DEBUGSS source is at a
           different input on each SoC.
      
      Fix the above issues by using a OMAP5-specific compatible property
      and using SoC-specific data where there are differences.
      Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
      Acked-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      e7309c26
    • Illia Smyrnov's avatar
      bus: omap_l3_noc: Fix offset for DRA7 CLK1_HOST_CLK1_2 instance · 4adf82c3
      Illia Smyrnov authored
      The base address for DRA7 CLK1_HOST_CLK1_2 host instance is
      0x44800000, so correct offset is 0x800000. DRA7 TRM rev X(fewb 2015)
      has updates for this information.
      
      With wrong offset these errors are not correctly cleared by the L3
      IRQ handler and cause an continuous interrupt scenario and system lockup.
      Signed-off-by: default avatarIllia Smyrnov <illia.smyrnov@globallogic.com>
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      4adf82c3
  2. 11 Sep, 2014 1 commit
    • Nishanth Menon's avatar
      bus: omap_l3_noc: Fix connID for OMAP4 · 41fc619d
      Nishanth Menon authored
      Commit d4d8819e ("bus: omap_l3_noc: fix masterid detection")
      did the right thing in dropping the LSB 2 bits which is not part
      of the ConnID for NTTP master address. However, as part of that
      change, we should also have ensured that existing list of OMAP4 connID
      codes are also shifted by 2 bits to ensure that connIDs map to "Table
      13-18. ConnID Values" as provided in Technical Reference Manuals for
      OMAP4430(Rev AP, April 2014, SWPU220AP) and OMAP4460(Rev AB, April
      2014, SWPU234AB)
      
      Fixes: d4d8819e ("bus: omap_l3_noc: fix masterid detection")
      Reported-by: default avatarKristian Otnes <kotnes@cisco.com>
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      41fc619d
  3. 05 May, 2014 16 commits
  4. 19 Sep, 2012 1 commit
  5. 09 Jul, 2012 1 commit
  6. 24 Sep, 2011 4 commits
    • sricharan's avatar
      OMAP: Print Initiator name for l3 custom error. · 551a9fa9
      sricharan authored
      The initiator id gets logged in the l3 target registers for custom error.
      So print it to aid debugging.
      
      Based on a internal patch by Devaraj Rangasamy <dev@ti.com>
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      551a9fa9
    • sricharan's avatar
      OMAP: Fix sparse warnings in l3 error handler. · 6616aac6
      sricharan authored
      Fix below sparse warnings from the l3-noc and l3-smx error handlers
      files.
      
      arch/arm/mach-omap2/omap_l3_smx.h:209:22: warning: symbol 'omap3_l3_app_bases' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_smx.h:308:22: warning: symbol 'omap3_l3_debug_bases' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_smx.h:325:2: warning: incorrect type in initializer (different address spaces)
      arch/arm/mach-omap2/omap_l3_smx.h:325:2:    expected unsigned int [usertype] *
      arch/arm/mach-omap2/omap_l3_smx.h:325:2:    got unsigned int [noderef] [toplevel] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_smx.h:326:2: warning: incorrect type in initializer (different address spaces)
      arch/arm/mach-omap2/omap_l3_smx.h:326:2:    expected unsigned int [usertype] *
      arch/arm/mach-omap2/omap_l3_smx.h:326:2:    got unsigned int [noderef] [toplevel] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_smx.h:324:5: warning: symbol 'omap3_l3_bases' was not declared. Should it be static?
        CC      arch/arm/mach-omap2/omap_l3_smx.o
        CHECK   arch/arm/mach-omap2/omap_l3_noc.c
      arch/arm/mach-omap2/omap_l3_noc.c:73:13: warning: symbol '__v' shadows an earlier one
      arch/arm/mach-omap2/omap_l3_noc.c:73:13: originally declared here
      arch/arm/mach-omap2/omap_l3_noc.c:83:20: warning: symbol '__v' shadows an earlier one
      arch/arm/mach-omap2/omap_l3_noc.c:83:20: originally declared here
      arch/arm/mach-omap2/omap_l3_noc.c:90:5: warning: symbol '__v' shadows an earlier one
      arch/arm/mach-omap2/omap_l3_noc.c:90:5: originally declared here
      arch/arm/mach-omap2/omap_l3_noc.h:39:5: warning: symbol 'l3_flagmux' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:46:5: warning: symbol 'l3_targ_inst_clk1' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:54:5: warning: symbol 'l3_targ_inst_clk2' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:75:5: warning: symbol 'l3_targ_inst_clk3' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:79:6: warning: symbol 'l3_targ_inst_name' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:112:5: warning: symbol 'l3_targ' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.c:72:11: warning: cast removes address space of expression
      arch/arm/mach-omap2/omap_l3_noc.c:73:13: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:73:13:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:73:13:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:83:20: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:83:20:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:83:20:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:90:5: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:90:5:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:90:5:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:96:5: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:96:5:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:96:5:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:108:5: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:108:5:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:108:5:    got unsigned int
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      Reported-by: default avatarPaul Walmsley <paul@pwsan.com>
      Reviewed-by: default avatarPaul Walmsley <paul@pwsan.com>
      6616aac6
    • sricharan's avatar
      OMAP: Fix indentation issues in l3 error handler. · ed0e3520
      sricharan authored
      The indentation problems in the l3 noc and smx
      error handler files are fixed.
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      Reported-by: default avatarPaul Walmsley <paul@pwsan.com>
      ed0e3520
    • Todd Poynor's avatar
      OMAP: Improve register access in L3 Error handler. · 342fd144
      Todd Poynor authored
      * Changed the way of accessing L3 target
        registers from standard base rather
        than relative to STDERRLOG_MAIN.
      
      * Use ffs() to find error source from
        the L3_FLAGMUX_REGERRn register.
      
      * Remove extra l3_base[] entry.
      
      * Modified L3 custom error message.
      Signed-off-by: default avatarTodd Poynor <toddpoynor@google.com>
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      342fd144
  7. 09 Mar, 2011 1 commit