• Geert Uytterhoeven's avatar
    firewire: IEEE 1394 (FireWire) support should depend on HAS_DMA · 655fc39b
    Geert Uytterhoeven authored
    Commit b3d681a4 ("firewire: Use
    COMPILE_TEST for build testing") added COMPILE_TEST as an alternative
    dependency for the purpose of build testing the firewire core.
    However, this bypasses all other implicit dependencies assumed by PCI,
    like HAS_DMA.
    
    If NO_DMA=y:
    
        drivers/built-in.o: In function `fw_iso_buffer_destroy':
        (.text+0x36a096): undefined reference to `dma_unmap_page'
        drivers/built-in.o: In function `fw_iso_buffer_map_dma':
        (.text+0x36a164): undefined reference to `dma_map_page'
        drivers/built-in.o: In function `fw_iso_buffer_map_dma':
        (.text+0x36a172): undefined reference to `dma_mapping_error'
        drivers/built-in.o: In function `sbp2_send_management_orb':
        sbp2.c:(.text+0x36c6b4): undefined reference to `dma_map_single'
        sbp2.c:(.text+0x36c6c8): undefined reference to `dma_mapping_error'
        sbp2.c:(.text+0x36c772): undefined reference to `dma_map_single'
        sbp2.c:(.text+0x36c786): undefined reference to `dma_mapping_error'
        sbp2.c:(.text+0x36c854): undefined reference to `dma_unmap_single'
        sbp2.c:(.text+0x36c872): undefined reference to `dma_unmap_single'
        drivers/built-in.o: In function `sbp2_map_scatterlist':
        sbp2.c:(.text+0x36ccbc): undefined reference to `scsi_dma_map'
        sbp2.c:(.text+0x36cd36): undefined reference to `dma_map_single'
        sbp2.c:(.text+0x36cd4e): undefined reference to `dma_mapping_error'
        sbp2.c:(.text+0x36cd84): undefined reference to `scsi_dma_unmap'
        drivers/built-in.o: In function `sbp2_unmap_scatterlist':
        sbp2.c:(.text+0x36cda6): undefined reference to `scsi_dma_unmap'
        sbp2.c:(.text+0x36cdc6): undefined reference to `dma_unmap_single'
        drivers/built-in.o: In function `complete_command_orb':
        sbp2.c:(.text+0x36d6ac): undefined reference to `dma_unmap_single'
        drivers/built-in.o: In function `sbp2_scsi_queuecommand':
        sbp2.c:(.text+0x36d8e0): undefined reference to `dma_map_single'
        sbp2.c:(.text+0x36d8f6): undefined reference to `dma_mapping_error'
    
    Add an explicit dependency on HAS_DMA to fix this.
    Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    655fc39b