Commit 3d2b3c70 authored by Matthias Reichl's avatar Matthias Reichl Committed by Mark Brown

ASoC: bcm2835: Enforce full symmetry

bcm2835's configuration registers can't be changed when a stream
is running, which means asymmetric configurations aren't supported.

Channel and rate symmetry are already enforced by constraints
but samplebits had been missed.

As hw_params doesn't check for symmetry constraints by itself
and just returns success if a stream is running this led to
situations where asymmetric configurations were seeming to
succeed but of course didn't work because the hardware wasn't
configured at all.

Fix this by adding the missing samplerate symmetry constraint.
Signed-off-by: default avatarMatthias Reichl <>
Signed-off-by: default avatarMark Brown <>
parent 675c0ee5
......@@ -737,7 +737,8 @@ static struct snd_soc_dai_driver bcm2835_i2s_dai = {
.ops = &bcm2835_i2s_dai_ops,
.symmetric_rates = 1
.symmetric_rates = 1,
.symmetric_samplebits = 1,
static bool bcm2835_i2s_volatile_reg(struct device *dev, unsigned int reg)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment