Commit 63cd4489 authored by Mike Kravetz's avatar Mike Kravetz Committed by Linus Torvalds

mm/cma: fix alloc_contig_range ret code/potential leak

If the call __alloc_contig_migrate_range() in alloc_contig_range returns
-EBUSY, processing continues so that test_pages_isolated() is called
where there is a tracepoint to identify the busy pages.  However, it is
possible for busy pages to become available between the calls to these
two routines.  In this case, the range of pages may be allocated.
Unfortunately, the original return code (ret == -EBUSY) is still set and
returned to the caller.  Therefore, the caller believes the pages were
not allocated and they are leaked.

Update the comment to indicate that allocation is still possible even if
__alloc_contig_migrate_range returns -EBUSY.  Also, clear return code in
this case so that it is not accidentally used or returned to caller.

Fixes: 8ef5849f ("mm/cma: always check which page caused allocation failure")
Signed-off-by: default avatarMike Kravetz <>
Acked-by: default avatarVlastimil Babka <>
Acked-by: default avatarMichal Hocko <>
Acked-by: default avatarJohannes Weiner <>
Acked-by: default avatarJoonsoo Kim <>
Cc: Michal Nazarewicz <>
Cc: Laura Abbott <>
Cc: Michal Hocko <>
Cc: Mel Gorman <>
Cc: <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 687cb088
......@@ -7652,11 +7652,18 @@ int alloc_contig_range(unsigned long start, unsigned long end,
* In case of -EBUSY, we'd like to know which page causes problem.
* So, just fall through. We will check it in test_pages_isolated().
* So, just fall through. test_pages_isolated() has a tracepoint
* which will report the busy page.
* It is possible that busy pages could become available before
* the call to test_pages_isolated, and the range will actually be
* allocated. So, if we fall through be sure to clear ret so that
* -EBUSY is not accidentally used or returned to caller.
ret = __alloc_contig_migrate_range(&cc, start, end);
if (ret && ret != -EBUSY)
goto done;
ret =0;
* Pages from [start, end) are within a MAX_ORDER_NR_PAGES
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment