1. 24 Feb, 2017 2 commits
    • Bhumika Goyal's avatar
      watchdog: constify watchdog_ops structures · b893e344
      Bhumika Goyal authored
      Declare watchdog_ops structures as const as they are only stored in the
      ops field of a watchdog_device structure. This field is of type const, so
      watchdog_ops structures having this property can be made const too.
      Done using Coccinelle:
      
      @r disable optional_qualifier@
      identifier x;
      position p;
      @@
      static struct watchdog_ops x@p={...};
      
      @ok@
      struct watchdog_device w;
      identifier r.x;
      position p;
      @@
      w.ops=&x@p;
      
      @bad@
      position p != {r.p,ok.p};
      identifier r.x;
      @@
      x@p
      
      @depends on !bad disable optional_qualifier@
      identifier r.x;
      @@
      +const
      struct watchdog_ops x;
      
      File size details before and after patching.
      First line of every .o file shows the file size before patching
      and second line shows the size after patching.
      
         text    data     bss     dec     hex filename
      
         1340	    544	      0	   1884	    75c	drivers/watchdog/bcm_kona_wdt.o
         1436	    440	      0	   1876	    754	drivers/watchdog/bcm_kona_wdt.o
      
         1176	    544	      4	   1724	    6bc	drivers/watchdog/digicolor_wdt.o
         1272	    440	      4	   1716	    6b4	drivers/watchdog/digicolor_wdt.o
      
          925	    580	     89	   1594	    63a	drivers/watchdog/ep93xx_wdt.o
         1021	    476	     89	   1586	    632	drivers/watchdog/ep93xx_wdt.o
      
         4932	    288	     17	   5237	   1475	drivers/watchdog/s3c2410_wdt.o
         5028	    192	     17	   5237	   1475	drivers/watchdog/s3c2410_wdt.o
      
         1977	    292	      1	   2270	    8de	drivers/watchdog/sama5d4_wdt.o
         2073	    196	      1	   2270	    8de	drivers/watchdog/sama5d4_wdt.o
      
         1375	    484	      1	   1860	    744	drivers/watchdog/sirfsoc_wdt.o
         1471	    380	      1	   1852	    73c	drivers/watchdog/sirfsoc_wdt.o
      
      Size remains the same for the files drivers/watchdog/diag288_wdt.o
      drivers/watchdog/asm9260_wdt.o and drivers/watchdog/atlas7_wdt.o
      
      The following .o files did not compile:
      drivers/watchdog/sun4v_wdt.o, drivers/watchdog/sbsa_gwdt.o,
      drivers/watchdog/rt2880_wdt.o, drivers/watchdog/booke_wdt.o
      drivers/watchdog/mt7621_wdt.o
      Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
      Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      b893e344
    • Bhumika Goyal's avatar
      watchdog: booke_wdt: add __ro_after_init to booke_wdt_info · 8d97005e
      Bhumika Goyal authored
      The object booke_wdt_info of watchdog_info structure is not
      modified after getting initialized by booke_wdt_init. Apart from getting
      referenced in init it is also stored in the info field of watchdog_device
      structure which is of type const struct watchdog_info *info. So, it
      becomes read only after init and therefore add __ro_after_init to it's
      declaration.
      Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      8d97005e
  2. 09 Sep, 2015 1 commit
  3. 20 Oct, 2014 1 commit
  4. 10 Jun, 2014 1 commit
  5. 20 Mar, 2014 1 commit
  6. 25 Jun, 2013 1 commit
  7. 01 Mar, 2013 1 commit
  8. 19 Nov, 2012 1 commit
  9. 17 Aug, 2012 1 commit
  10. 10 Jul, 2012 1 commit
  11. 28 Mar, 2012 1 commit
  12. 27 Mar, 2012 1 commit
  13. 29 Feb, 2012 1 commit
  14. 15 Mar, 2011 1 commit
    • Timur Tabi's avatar
      watchdog: booke_wdt: clean up status messages · 112e7546
      Timur Tabi authored
      Improve the status messages that are displayed during some operations of the
      PowerPC watchdog timer driver.  When the watchdog is enabled, the timeout is
      displayed as a number of seconds, instead of an obscure "period".  The "period"
      is the position of a bit in a 64-bit timer register.  The higher the value,
      the quicker the watchdog timeout occurs.  Some people chose a high "period"
      value for the timer and get confused as to why the board resets within a
      few seconds.
      
      Messages displayed during open and close are now debug messages, so that they
      don't clutter the console by default.  Finally, printk() is replaced with the
      pr_xxx() equivalent.
      Signed-off-by: default avatarTimur Tabi <timur@freescale.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      112e7546
  15. 12 Jan, 2011 2 commits
  16. 14 Oct, 2010 2 commits
  17. 25 May, 2010 1 commit
  18. 27 Apr, 2010 1 commit
  19. 16 Apr, 2010 1 commit
  20. 07 Mar, 2010 1 commit
  21. 18 Sep, 2009 1 commit
  22. 08 Nov, 2008 1 commit
  23. 06 Aug, 2008 1 commit
    • Wim Van Sebroeck's avatar
      [WATCHDOG] Coding style - Indentation - part 2 · 0c06090c
      Wim Van Sebroeck authored
      This brings the watchdog drivers into line with coding style.
      This patch takes cares of the indentation as described in chapter 1.
      Main changes:
      * Re-structure the ioctl switch call for all drivers as follows:
      	switch (cmd) {
      	case WDIOC_GETSUPPORT:
      	case WDIOC_GETSTATUS:
      	case WDIOC_GETBOOTSTATUS:
      	case WDIOC_GETTEMP:
      	case WDIOC_SETOPTIONS:
      	case WDIOC_KEEPALIVE:
      	case WDIOC_SETTIMEOUT:
      	case WDIOC_GETTIMEOUT:
      	case WDIOC_GETTIMELEFT:
      	default:
      	}
      
      This to make the migration from the drivers to the uniform watchdog
      device driver easier in the future.
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      0c06090c
  24. 15 Jul, 2008 1 commit
  25. 13 Jun, 2008 1 commit
  26. 25 May, 2008 1 commit
  27. 18 Oct, 2007 1 commit
  28. 23 Jul, 2007 1 commit
  29. 17 May, 2007 1 commit
  30. 08 Feb, 2007 1 commit
  31. 02 Oct, 2006 1 commit
  32. 03 Jul, 2006 1 commit
  33. 30 Jun, 2006 1 commit
  34. 16 Dec, 2005 1 commit
  35. 15 Dec, 2005 1 commit
  36. 14 Nov, 2005 1 commit
  37. 05 Sep, 2005 1 commit