1. 16 Mar, 2016 4 commits
  2. 23 Nov, 2015 2 commits
    • Vladimir Zapolskiy's avatar
      watchdog: pnx4008: make global wdt_clk static · 4c30737c
      Vladimir Zapolskiy authored
      Silences sparse warning:
      
        drivers/watchdog/pnx4008_wdt.c:83:25:
          warning: symbol 'wdt_clk' was not declared. Should it be static?
      Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      4c30737c
    • Vladimir Zapolskiy's avatar
      watchdog: pnx4008: fix warnings caused by enabling unprepared clock · b647d429
      Vladimir Zapolskiy authored
      If common clock framework is configured, the driver generates a warning,
      which is fixed by this change:
      
          WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:727 clk_core_enable+0x2c/0xa4()
          Modules linked in:
          CPU: 0 PID: 1 Comm: swapper Tainted: G        W       4.3.0-rc2+ #171
          Hardware name: LPC32XX SoC (Flattened Device Tree)
          Backtrace:
          [<>] (dump_backtrace) from [<>] (show_stack+0x18/0x1c)
          [<>] (show_stack) from [<>] (dump_stack+0x20/0x28)
          [<>] (dump_stack) from [<>] (warn_slowpath_common+0x90/0xb8)
          [<>] (warn_slowpath_common) from [<>] (warn_slowpath_null+0x24/0x2c)
          [<>] (warn_slowpath_null) from [<>] (clk_core_enable+0x2c/0xa4)
          [<>] (clk_core_enable) from [<>] (clk_enable+0x24/0x38)
          [<>] (clk_enable) from [<>] (pnx4008_wdt_probe+0x78/0x11c)
          [<>] (pnx4008_wdt_probe) from [<>] (platform_drv_probe+0x50/0xa0)
          [<>] (platform_drv_probe) from [<>] (driver_probe_device+0x18c/0x408)
          [<>] (driver_probe_device) from [<>] (__driver_attach+0x70/0x94)
          [<>] (__driver_attach) from [<>] (bus_for_each_dev+0x74/0x98)
          [<>] (bus_for_each_dev) from [<>] (driver_attach+0x20/0x28)
          [<>] (driver_attach) from [<>] (bus_add_driver+0x11c/0x248)
          [<>] (bus_add_driver) from [<>] (driver_register+0xa4/0xe8)
          [<>] (driver_register) from [<>] (__platform_driver_register+0x50/0x64)
          [<>] (__platform_driver_register) from [<>] (platform_wdt_driver_init+0x18/0x20)
          [<>] (platform_wdt_driver_init) from [<>] (do_one_initcall+0x11c/0x1dc)
          [<>] (do_one_initcall) from [<>] (kernel_init_freeable+0x10c/0x1d4)
          [<>] (kernel_init_freeable) from [<>] (kernel_init+0x10/0xec)
          [<>] (kernel_init) from [<>] (ret_from_fork+0x14/0x24)
      Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      b647d429
  3. 09 Sep, 2015 1 commit
  4. 22 Apr, 2015 1 commit
  5. 20 Oct, 2014 1 commit
  6. 31 Mar, 2014 1 commit
  7. 10 Dec, 2013 1 commit
  8. 17 Nov, 2013 1 commit
    • Jean Delvare's avatar
      watchdog: Get rid of MODULE_ALIAS_MISCDEV statements · 487722cf
      Jean Delvare authored
      I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
      and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.
      
      Either the device is enumerated and the driver already has a module
      alias (e.g. PCI, USB etc.) that will get the right driver loaded
      automatically.
      
      Or the device is not enumerated and loading its driver will lead to
      more or less intrusive hardware poking. Such hardware poking should be
      limited to a bare minimum, so the user should really decide which
      drivers should be tried and in what order. Trying them all in
      arbitrary order can't do any good.
      
      On top of that, loading that many drivers at once bloats the kernel
      log. Also many drivers will stay loaded afterward, bloating the output
      of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
      loaded as a dependency) can't even be unloaded!
      
      If defining char-major-10-130 is needed then it should happen in
      user-space.
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      Cc: Stephen Warren <swarren@wwwdotorg.org>
      Cc: Mike Frysinger <vapier.adi@gmail.com>
      Cc: Wan ZongShun <mcuos.com@gmail.com>
      Cc: Ben Dooks <ben-linux@fluff.org>
      Cc: Kukjin Kim <kgene.kim@samsung.com>
      Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>
      Cc: Jim Cromie <jim.cromie@gmail.com>
      487722cf
  9. 11 Jul, 2013 1 commit
  10. 01 Mar, 2013 1 commit
    • Fabio Porcedda's avatar
      watchdog: add timeout-sec property binding · c1fd5f64
      Fabio Porcedda authored
      this patchset add the timeout-sec property to the following drivers:
      orion_wdt, pnx4008_wdt, s3c2410_wdt and at91sam9_wdt.
      
      The at91sam9_wdt is tested on evk-pr3,
      the other drivers are compile tested only.
      Signed-off-by: default avatarFabio Porcedda <fabio.porcedda@gmail.com>
      Cc: Andrew Lunn <andrew@lunn.ch>
      Cc: Jason Cooper <jason@lakedaemon.net>
      Cc: Wolfram Sang <w.sang@pengutronix.de>
      Cc: Masanari Iida <standby24x7@gmail.com>
      Cc: Ben Dooks <ben-linux@fluff.org>
      Cc: Kukjin Kim <kgene.kim@samsung.com>
      Cc: Andrew Victor <linux@maxim.org.za>
      Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
      Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      c1fd5f64
  11. 25 Jan, 2013 1 commit
  12. 28 Nov, 2012 3 commits
  13. 23 May, 2012 1 commit
  14. 27 Mar, 2012 6 commits
  15. 28 Feb, 2012 1 commit
  16. 21 Feb, 2012 1 commit
  17. 27 Jan, 2012 1 commit
  18. 06 Jan, 2012 1 commit
    • Axel Lin's avatar
      watchdog: convert drivers/watchdog/* to use module_platform_driver() · b8ec6118
      Axel Lin authored
      This patch converts the drivers in drivers/watchdog/* to use the
      module_platform_driver() macro which makes the code smaller and a bit
      simpler.
      Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
      Cc: Nicolas Thill <nico@openwrt.org>
      Cc: Florian Fainelli <florian@openwrt.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Paul Cercueil <paul@crapouillou.net>
      Cc: Marc Zyngier <maz@misterjones.org>
      Cc: Wan ZongShun <mcuos.com@gmail.com>
      Cc: Alejandro Cabrera <aldaya@gmail.com>
      Cc: "George G. Davis" <gdavis@mvista.com>
      Cc: Sylver Bruneau <sylver.bruneau@googlemail.com>
      Cc: Vitaly Wool <vital@embeddedalley.com>
      Cc: Mika Westerberg <mika.westerberg@iki.fi>
      Cc: Timo Kokkonen <timo.t.kokkonen@nokia.com>
      Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
      b8ec6118
  19. 29 Mar, 2011 1 commit
  20. 15 Mar, 2011 1 commit
  21. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  22. 12 Feb, 2010 2 commits
  23. 23 Dec, 2009 1 commit
  24. 20 Nov, 2009 1 commit
  25. 18 Jun, 2009 1 commit
  26. 25 Mar, 2009 1 commit
  27. 23 Sep, 2008 1 commit
  28. 07 Aug, 2008 1 commit