1. 07 Nov, 2017 1 commit
  2. 03 Nov, 2017 1 commit
  3. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
         lines).
      
      All documentation files were explicitly excluded.
      
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
      
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
      
         For non */uapi/* files that summary was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0                                              11139
      
         and resulted in the first patch in this series.
      
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0 WITH Linux-syscall-note                        930
      
         and resulted in the second patch in this series.
      
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|------
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
      
         and that resulted in the third patch in this series.
      
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
      
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
      
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
      
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
      
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
  4. 13 Oct, 2017 2 commits
  5. 12 Oct, 2017 1 commit
    • Jan Luebbe's avatar
      bus: mbus: fix window size calculation for 4GB windows · 2bbbd963
      Jan Luebbe authored
      At least the Armada XP SoC supports 4GB on a single DRAM window. Because
      the size register values contain the actual size - 1, the MSB is set in
      that case. For example, the SDRAM window's control register's value is
      0xffffffe1 for 4GB (bits 31 to 24 contain the size).
      
      The MBUS driver reads back each window's size from registers and
      calculates the actual size as (control_reg | ~DDR_SIZE_MASK) + 1, which
      overflows for 32 bit values, resulting in other miscalculations further
      on (a bad RAM window for the CESA crypto engine calculated by
      mvebu_mbus_setup_cpu_target_nooverlap() in my case).
      
      This patch changes the type in 'struct mbus_dram_window' from u32 to
      u64, which allows us to keep using the same register calculation code in
      most MBUS-using drivers (which calculate ->size - 1 again).
      
      Fixes: fddddb52 ("bus: introduce an Marvell EBU MBus driver")
      CC: stable@vger.kernel.org
      Signed-off-by: default avatarJan Luebbe <jlu@pengutronix.de>
      Signed-off-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
      2bbbd963
  6. 10 Oct, 2017 1 commit
    • Tony Lindgren's avatar
      bus: ti-sysc: Add minimal TI sysc interconnect target driver · 0eecc636
      Tony Lindgren authored
      We can handle the sysc interconnect target module in a generic way
      for many TI SoCs. Initially let's just enable runtime PM with
      autosuspend, and probe the children. This can already be used for
      idling interconnect target modules that don't have any device driver
      available for the child devices.
      
      For now, the "ti,hwmods" custom binding is still required. That will
      be eventually deprecated in later patches. And more features will be
      added, such as parsing for sysc capabilities so we can continue
      removing the legacy platform data.
      
      Cc: Benoît Cousson <bcousson@baylibre.com>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
      Cc: Nishanth Menon <nm@ti.com>
      Cc: Matthijs van Duin <matthijsvanduin@gmail.com>
      Cc: Paul Walmsley <paul@pwsan.com>
      Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
      Cc: Sakari Ailus <sakari.ailus@iki.fi>
      Cc: Tero Kristo <t-kristo@ti.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-kernel@vger.kernel.org
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      0eecc636
  7. 18 Aug, 2017 1 commit
  8. 16 Aug, 2017 1 commit
  9. 04 Aug, 2017 1 commit
  10. 12 Jul, 2017 1 commit
  11. 23 Jun, 2017 3 commits
  12. 17 Jun, 2017 1 commit
  13. 14 May, 2017 6 commits
  14. 17 Jan, 2017 1 commit
  15. 02 Jan, 2017 1 commit
  16. 25 Dec, 2016 2 commits
  17. 30 Nov, 2016 1 commit
  18. 23 Nov, 2016 1 commit
  19. 15 Nov, 2016 1 commit
  20. 14 Nov, 2016 1 commit
  21. 17 Oct, 2016 2 commits
  22. 03 Oct, 2016 1 commit
  23. 08 Sep, 2016 2 commits
  24. 06 Sep, 2016 1 commit
  25. 02 Sep, 2016 2 commits
  26. 26 Aug, 2016 3 commits
    • Mark Rutland's avatar
      bus: arm-ccn: make event groups reliable · d662ed2e
      Mark Rutland authored
      The CCN PMU driver leaves the counting logic always enabled, and thus
      events are enabled while groups are manipulated. As each event is
      stopped and read individually, this leads to arbitrary skew across event
      groups, which can be seen if counting several identical events.
      
      To avoid this, implement pmu_{enable,disable} callbacks to stop and
      start all counters atomically around event manipulation. As the counters
      are now stopped, we cannot poll the cycle counter to wait for events to
      drain from the bus. However, as the counters are stopped and the events
      will not be read regardless, we can simply allow the bus to drain
      naturally.
      Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
      Signed-off-by: default avatarPawel Moll <pawel.moll@arm.com>
      d662ed2e
    • Mark Rutland's avatar
      bus: arm-ccn: fix hrtimer registration · 5b1e01f3
      Mark Rutland authored
      The CCN PMU driver has a single hrtimer, used to simulate a periodic
      interrupt on systems where the overflow interrupt is not possible to
      use. The hrtimer is started when any event is started, and cancelled when
      any event is stopped. Thus, stopping a single event is sufficient to
      disable to hrtimer, and overflows (of other events) may be lost.
      
      To avoid this, this patch reworks the hrtimer start/cancel to only occur
      when the first event is added to a PMU, and the last event removed,
      making use of the existing bitmap counting active events.
      Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
      Signed-off-by: default avatarPawel Moll <pawel.moll@arm.com>
      5b1e01f3
    • Mark Rutland's avatar
      bus: arm-ccn: fix PMU interrupt flags · 0811ef7e
      Mark Rutland authored
      Currently the IRQ core is permitted to make the CCN PMU IRQ handler
      threaded, and will allow userspace to change the CPU affinity of the
      interrupt behind our back. Both of these could violate our
      synchronisation requirements with the core perf code, which relies upon
      strict CPU affinity and disabling of interrupts to guarantee mutual
      exclusion in some cases.
      
      As with the CPU PMU drivers, we should request the interrupt with
      IRQF_NOBALANCING and IRQF_NO_THREAD, to avoid these issues.
      Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
      Acked-by: default avatarPawel Moll <pawel.moll@arm.com>
      Reviewed-by: default avatarWill Deacon <will.deacon@arm.com>
      Signed-off-by: default avatarPawel Moll <pawel.moll@arm.com>
      0811ef7e