1. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      How this work was done:
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
      All documentation files were explicitly excluded.
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
         For non */uapi/* files that summary was:
         SPDX license identifier                            # files
         GPL-2.0                                              11139
         and resulted in the first patch in this series.
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                        930
         and resulted in the second patch in this series.
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
         and that resulted in the third patch in this series.
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  2. 31 Oct, 2017 1 commit
    • Kees Cook's avatar
      treewide: Fix function prototypes for module_param_call() · e4dca7b7
      Kees Cook authored
      Several function prototypes for the set/get functions defined by
      module_param_call() have a slightly wrong argument types. This fixes
      those in an effort to clean up the calls when running under type-enforced
      compiler instrumentation for CFI. This is the result of running the
      following semantic patch:
      declarer name module_param_call;
      identifier _name, _set_func, _get_func;
      expression _arg, _mode;
       module_param_call(_name, _set_func, _get_func, _arg, _mode);
       depends on match_module_param_call_function@
      identifier match_module_param_call_function._set_func;
      identifier _val, _param;
      type _val_type, _param_type;
       int _set_func(
      -_val_type _val
      +const char * _val
      -_param_type _param
      +const struct kernel_param * _param
       ) { ... }
       depends on match_module_param_call_function@
      identifier match_module_param_call_function._get_func;
      identifier _val, _param;
      type _val_type, _param_type;
       int _get_func(
      -_val_type _val
      +char * _val
      -_param_type _param
      +const struct kernel_param * _param
       ) { ... }
      Two additional by-hand changes are included for places where the above
      Coccinelle script didn't notice them:
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
  3. 30 Aug, 2017 1 commit
  4. 25 Aug, 2017 2 commits
  5. 07 Aug, 2017 1 commit
    • Arnd Bergmann's avatar
      scsi: fusion: fix string overflow warning · b192b42a
      Arnd Bergmann authored
      gcc points out a theorerical string overflow:
      drivers/message/fusion/mptbase.c: In function 'mpt_detach':
      drivers/message/fusion/mptbase.c:2103:17: error: '%s' directive writing up to 31 bytes into a region of size 28 [-Werror=format-overflow=]
      sprintf(pname, MPT_PROCFS_MPTBASEDIR "/%s/summary", ioc->name);
      drivers/message/fusion/mptbase.c:2103:2: note: 'sprintf' output between 13 and 44 bytes into a destination of size 32
      We can simply double the size of the local buffer here to be on the
      safe side, and using snprintf() instead of sprintf() protects us
      if ioc->name was not terminated properly.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
  6. 24 Apr, 2017 2 commits
  7. 07 Feb, 2017 1 commit
  8. 27 Jan, 2017 1 commit
  9. 05 Jan, 2017 1 commit
  10. 24 Dec, 2016 1 commit
  11. 18 Nov, 2016 1 commit
  12. 08 Nov, 2016 2 commits
  13. 20 Oct, 2016 1 commit
    • Jarod Wilson's avatar
      net: use core MTU range checking in misc drivers · b3e3893e
      Jarod Wilson authored
      - set min/max_mtu
      - remove fwnet_change_mtu
      - set max_mtu
      - clean up nes_netdev_change_mtu
      - set min/max_mtu
      - remove xpnet_dev_change_mtu
      - set min/max_mtu
      - remove hippi_change_mtu
      - set max_mtu
      - remove batadv_interface_change_mtu
      - initialization is a little async, not 100% certain that max_mtu is set
        in the optimal place, don't have hardware to test with
      - set min/max_mtu
      - remove rionet_change_mtu
      - set min/max_mtu
      - streamline sl_change_mtu
      - remove pointless ndo_change_mtu
      - use core MTU range checking
      - remove now redundant ssip_pn_set_mtu
      - set a default max MTU value
      - Note: ipoib's actual max MTU can vary, depending on if the device is in
        connected mode or not, so we'll just set the max_mtu value to the max
        possible, and let the ndo_change_mtu function continue to validate any new
        MTU change requests with checks for CM or not. Note that ipoib has no
        min_mtu set, and thus, the network core's mtu > 0 check is the only lower
        bounds here.
      - use net core MTU range checking
      - remove now redundant mpt_lan_change_mtu
      - min_mtu = 21, max_mtu = 4470
      - remove now redundant fddi_change_mtu (including export)
      - min_mtu = 8192, max_mtu = 65536
      - The max_mtu value is actually one over IP_MAX_MTU here, but the idea is to
        get past the core net MTU range checks so fjes_change_mtu can validate a
        new MTU against what it supports (see fjes_support_mtu in fjes_hw.c)
      - min_mtu = 0 (calls ether_setup, max_mtu is 1500)
      - min_mtu = 6, max_mtu = 65541
      - min_mtu = 14, max_mtu = 15412
      - min_mtu = 576, max_mtu = 65530
      - remove redundant gprs_set_mtu
      CC: netdev@vger.kernel.org
      CC: linux-rdma@vger.kernel.org
      CC: Stefan Richter <stefanr@s5r6.in-berlin.de>
      CC: Faisal Latif <faisal.latif@intel.com>
      CC: linux-rdma@vger.kernel.org
      CC: Cliff Whickman <cpw@sgi.com>
      CC: Robin Holt <robinmholt@gmail.com>
      CC: Jes Sorensen <jes@trained-monkey.org>
      CC: Marek Lindner <mareklindner@neomailbox.ch>
      CC: Simon Wunderlich <sw@simonwunderlich.de>
      CC: Antonio Quartulli <a@unstable.cc>
      CC: Sathya Prakash <sathya.prakash@broadcom.com>
      CC: Chaitra P B <chaitra.basappa@broadcom.com>
      CC: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
      CC: MPT-FusionLinux.pdl@broadcom.com
      CC: Sebastian Reichel <sre@kernel.org>
      CC: Felipe Balbi <balbi@kernel.org>
      CC: Arvid Brodin <arvid.brodin@alten.se>
      CC: Remi Denis-Courmont <courmisch@gmail.com>
      Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  14. 14 Sep, 2016 1 commit
  15. 02 Sep, 2016 2 commits
  16. 04 May, 2016 1 commit
  17. 29 Apr, 2016 1 commit
  18. 11 Apr, 2016 1 commit
  19. 24 Feb, 2016 2 commits
  20. 12 Nov, 2015 1 commit
  21. 10 Nov, 2015 1 commit
  22. 26 Aug, 2015 1 commit
  23. 13 Jun, 2015 2 commits
  24. 03 Feb, 2015 1 commit
    • Alan Cox's avatar
      i2o: move to staging · 2cbf7fe2
      Alan Cox authored
      The I2O layer deals with a technology that to say the least didn't catch on
      in the market.
      The only relevant products are some of the AMI MegaRAID - which supported I2O
      and its native mode (The native mode is faster and runs on Linux), an
      obscure crypto ethernet card that's now so many years out of date nobody
      would use it, the old DPT controllers, which speak their own dialect and
      have their own driver - and ermm.. thats about it.
      We also know the code isn't in good shape as recently a patch was proposed
      and queried as buggy, which in turn showed the existing code was broken
      already by prior "clean up" and nobody had noticed that either.
      It's coding style robot code nothing more. Like some forgotten corridor
      cleaned relentlessly by a lost Roomba but where no user has trodden in years.
      Move it to staging and then to /dev/null.
      The headers remain as they are shared with dpt_i2o.
      Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  25. 24 Nov, 2014 1 commit
  26. 12 Nov, 2014 4 commits
  27. 25 Sep, 2014 1 commit
  28. 16 Sep, 2014 3 commits
  29. 25 Jul, 2014 1 commit
    • Joe Lawrence's avatar
      mptfusion: tweak null pointer checks · 9f21316f
      Joe Lawrence authored
      Fixes the following smatch warnings:
        drivers/message/fusion/mptbase.c:652 mptbase_reply() warn: variable
          dereferenced before check 'reply' (see line 639)
            [JL: No-brainer, the enclosing switch statement dereferences
             reply, so we can't get here unless reply is valid.]
        drivers/message/fusion/mptsas.c:1255 mptsas_taskmgmt_complete() error:
          we previously assumed 'pScsiTmReply' could be null (see line 1227)
            [HCH: Reading the code in mptsas_taskmgmt_complete it's pretty
             obvious that it can't do anything useful if mr/pScsiTmReply are
             NULL, so I suspect it would be best to just return at the
             beginning of the function.
             I'd love to understand if it actually could ever be zero, which I
             doubt.  Maybe the LSI people can shed some light on that?]
        drivers/message/fusion/mptsas.c:3888 mptsas_not_responding_devices()
          error: we previously assumed 'port_info->phy_info' could be null
          (see line 3875)
            [HCH: It's pretty obvious from reading mptsas_sas_io_unit_pg0 that
             we never register a port_info with a NULL phy_info in the lists,
             so all NULL checks on it could be deleted.]
        drivers/message/fusion/mptscsih.c:1284 mptscsih_info() error:
          we previously assumed 'h' could be null (see line 1274)
            [HCH: shost_priv can't return NULL, so the if (h) should be
        drivers/message/fusion/mptscsih.c:1388 mptscsih_qcmd() error: we
          previously assumed 'vdevice' could be null (see line 1373)
            [HCH: vdevice can't ever be NULL here, it's allocated in
             ->slave_alloc and thus guaranteed to be around when
             ->queuecommand is called.]
      Signed-off-by: default avatarJoe Lawrence <joe.lawrence@stratus.com>
      Acked-by: default avatarSreekanth Reddy <Sreekanth.Reddy@avagotech.com>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>