• Eugeniy Paltsev's avatar
    ARCv2: lib: memcpy: fix doing prefetchw outside of buffer · 8c8561af
    Eugeniy Paltsev authored
    [ Upstream commit f8a15f97664178f27dfbf86a38f780a532cb6df0 ]
    ARCv2 optimized memcpy uses PREFETCHW instruction for prefetching the
    next cache line but doesn't ensure that the line is not past the end of
    the buffer. PRETECHW changes the line ownership and marks it dirty,
    which can cause data corruption if this area is used for DMA IO.
    Fix the issue by avoiding the PREFETCHW. This leads to performance
    degradation but it is OK as we'll introduce new memcpy implementation
    optimized for unaligned memory access using.
    We also cut off all PREFETCH instructions at they are quite useless
     * we call PREFETCH right before LOAD instruction call.
     * we copy 16 or 32 bytes of data (depending on CONFIG_ARC_HAS_LL64)
       in a main logical loop. so we call PREFETCH 4 times (or 2 times)
       for each L1 cache line (in case of 64B L1 cache Line which is
       default case). Obviously this is not optimal.
    Signed-off-by: default avatarEugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
    Signed-off-by: default avatarVineet Gupta <vgupta@synopsys.com>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
memcpy-archs.S 4.44 KB