Skip to content
  • Cliff Wickman's avatar
    x86: UV: remove uv_flush_tlb_others() WARN_ON · 3a450de1
    Cliff Wickman authored
    
    
    In uv_flush_tlb_others() (arch/x86/kernel/tlb_uv.c),
    the "WARN_ON(!in_atomic())" fails if CONFIG_PREEMPT is not enabled.
    
    And CONFIG_PREEMPT is not enabled by default in the distribution that
    most UV owners will use.
    
    We could #ifdef CONFIG_PREEMPT the warning, but that is not good form.
    And there seems to be no suitable fix to in_atomic() when CONFIG_PREMPT
    is not on.
    
    As Ingo commented:
    
      > and we have no proper primitive to test for atomicity. (mainly
      > because we dont know about atomicity on a non-preempt kernel)
    
    So we drop the WARN_ON.
    
    Signed-off-by: default avatarCliff Wickman <cpw@sgi.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    3a450de1