Skip to content
  • Jakub Kicinski's avatar
    nfp: ignore signals when communicating with management FW · 5496295a
    Jakub Kicinski authored
    We currently allow signals to interrupt the wait for management FW
    commands.  Exiting the wait should not cause trouble, the FW will
    just finish executing the command in the background and new commands
    will wait for the old one to finish.
    
    However, this may not be what users expect (Ctrl-C not actually stopping
    the command).  Moreover some systems routinely request link information
    with signals pending (Ubuntu 14.04 runs a landscape-sysinfo python tool
    from MOTD) worrying users with errors like these:
    
    nfp 0000:04:00.0: nfp_nsp: Error -512 waiting for code 0x0007 to start
    nfp 0000:04:00.0: nfp: reading port table failed -512
    
    Make the wait for management FW responses non-interruptible.
    
    Fixes: 1a64821c
    
     ("nfp: add support for service processor access")
    Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
    Reviewed-by: default avatarDirk van der Merwe <dirk.vandermerwe@netronome.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5496295a