Skip to content
  • Sergey Senozhatsky's avatar
    zram: unify error reporting · 70864969
    Sergey Senozhatsky authored
    
    
    Make zram syslog error reporting more consistent. We have random
    error levels in some places. For example, critical errors like
      "Error allocating memory for compressed page"
    and
      "Unable to allocate temp memory"
    are reported as KERN_INFO messages.
    
    a) Reassign error levels
    
    Error messages that directly affect zram
    functionality -- pr_err():
    
     Error allocating zram address table
     Error creating memory pool
     Decompression failed! err=%d, page=%u
     Unable to allocate temp memory
     Compression failed! err=%d
     Error allocating memory for compressed page: %u, size=%zu
     Cannot initialise %s compressing backend
     Error allocating disk queue for device %d
     Error allocating disk structure for device %d
     Error creating sysfs group for device %d
     Unable to register zram-control class
     Unable to get major number
    
    Messages that do not affect functionality, but user
    must be warned (because sysfs attrs will be removed in
    this particular case) -- pr_warn():
    
     %d (%s) Attribute %s (and others) will be removed. %s
    
    Messages that do not affect functionality and mostly are
    informative -- pr_info():
    
     Cannot change max compression streams
     Can't change algorithm for initialized device
     Cannot change disksize for initialized device
     Added device: %s
     Removed device: %s
    
    b) Update sysfs_create_group() error message
    
    First, it lacks a trailing new line; add it.  Second, every error message
    in zram_add() has a "for device %d" part, which makes errors more
    informative.  Add missing part to "Error creating sysfs group" message.
    
    Signed-off-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
    Cc: Minchan Kim <minchan@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    70864969