• Herbert Xu's avatar
    crypto: seqiv - Stop using cryptoff · dd04446e
    Herbert Xu authored
    The cryptoff parameter was added to facilitate the skipping of
    IVs that sit between the AD and the plain/cipher text.  However,
    it was never implemented correctly as and we do not handle users
    such as IPsec setting cryptoff.  It is simply ignored.
    
    Implementing correctly is in fact more trouble than what it's
    worth.
    
    This patch removes the uses of cryptoff by moving the AD forward
    to fill the gap left by the IV.  The AD is moved back after the
    underlying AEAD processing is finished.
    
    This is in fact beter than the cryptoff solution because it allows
    algorithms that use seqniv (i.e., GCM and CCM) to hash the whole
    packet as a single piece, while cryptoff meant that there was
    guaranteed to be a gap.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    dd04446e
seqiv.c 22 KB