Skip to content
  • Xishi Qiu's avatar
    mem-hotplug: fix node spanned pages when we have a movable node · e506b996
    Xishi Qiu authored
    Commit 342332e6 ("mm/page_alloc.c: introduce kernelcore=mirror
    option") rewrote the calculation of node spanned pages.  But when we
    have a movable node, the size of node spanned pages is double added.
    That's because we have an empty normal zone, the present pages is zero,
    but its spanned pages is not zero.
    
    e.g.
        Zone ranges:
          DMA      [mem 0x0000000000001000-0x0000000000ffffff]
          DMA32    [mem 0x0000000001000000-0x00000000ffffffff]
          Normal   [mem 0x0000000100000000-0x0000007c7fffffff]
        Movable zone start for each node
          Node 1: 0x0000001080000000
          Node 2: 0x0000002080000000
          Node 3: 0x0000003080000000
          Node 4: 0x0000003c80000000
          Node 5: 0x0000004c80000000
          Node 6: 0x0000005c80000000
        Early memory node ranges
          node   0: [mem 0x0000000000001000-0x000000000009ffff]
          node   0: [mem 0x0000000000100000-0x000000007552afff]
          node   0: [mem 0x000000007bd46000-0x000000007bd46fff]
          node   0: [mem 0x000000007bdcd000-0x000000007bffffff]
          node   0: [mem 0x0000000100000000-0x000000107fffffff]
          node   1: [mem 0x0000001080000000-0x000000207fffffff]
          node   2: [mem 0x0000002080000000-0x000000307fffffff]
          node   3: [mem 0x0000003080000000-0x0000003c7fffffff]
          node   4: [mem 0x0000003c80000000-0x0000004c7fffffff]
          node   5: [mem 0x0000004c80000000-0x0000005c7fffffff]
          node   6: [mem 0x0000005c80000000-0x0000006c7fffffff]
          node   7: [mem 0x0000006c80000000-0x0000007c7fffffff]
    
      node1:
        Normal, start=0x1080000, present=0x0, spanned=0x1000000
        Movable, start=0x1080000, present=0x1000000, spanned=0x1000000
        pgdat, start=0x1080000, present=0x1000000, spanned=0x2000000
    
    After this patch, the problem is fixed.
    
      node1:
        Normal, start=0x0, present=0x0, spanned=0x0
        Movable, start=0x1080000, present=0x1000000, spanned=0x1000000
        pgdat, start=0x1080000, present=0x1000000, spanned=0x1000000
    
    Link: http://lkml.kernel.org/r/57A325E8.6070100@huawei.com
    
    
    Signed-off-by: default avatarXishi Qiu <qiuxishi@huawei.com>
    Cc: Taku Izumi <izumi.taku@jp.fujitsu.com>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Cc: Mel Gorman <mgorman@techsingularity.net>
    Cc: Michal Hocko <mhocko@suse.com>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Cc: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
    Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    e506b996