Commit 795f3def authored by Roman Kapl's avatar Roman Kapl Committed by Greg Kroah-Hartman

net: sched: report if filter is too large to dump

[ Upstream commit 5ae437ad ]

So far, if the filter was too large to fit in the allocated skb, the
kernel did not return any error and stopped dumping. Modify the dumper
so that it returns -EMSGSIZE when a filter fails to dump and it is the
first filter in the skb. If we are not first, we will get a next chance
with more room.

I understand this is pretty near to being an API change, but the
original design (silent truncation) can be considered a bug.

Note: The error case can happen pretty easily if you create a filter
with 32 actions and have 4kb pages. Also recent versions of iproute try
to be clever with their buffer allocation size, which in turn leads to
Signed-off-by: default avatarRoman Kapl <>
Acked-by: default avatarJiri Pirko <>
Acked-by: default avatarCong Wang <>
Signed-off-by: default avatarDavid S. Miller <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 60b28d5e
......@@ -871,13 +871,18 @@ static int tc_dump_tfilter(struct sk_buff *skb, struct netlink_callback *cb)
if (tca[TCA_CHAIN] &&
nla_get_u32(tca[TCA_CHAIN]) != chain->index)
if (!tcf_chain_dump(chain, skb, cb, index_start, &index))
if (!tcf_chain_dump(chain, skb, cb, index_start, &index)) {
err = -EMSGSIZE;
cb->args[0] = index;
/* If we did no progress, the error (EMSGSIZE) is real */
if (skb->len == 0 && err)
return err;
return skb->len;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment