Commit 7fa8b717 authored by Joel Fernandes's avatar Joel Fernandes Committed by Steven Rostedt

tracing/function_graph: Fix filters for function_graph threshold

Function graph tracer currently ignores filters if tracing_thresh is set.
For example, even if set_ftrace_pid is set, then its ignored if tracing_thresh
set, resulting in all processes being traced.

To fix this, we reuse the same entry function as when tracing_thresh is not
set and do everything as in the regular case except for writing the function entry
to the ring buffer.


Cc: Frederic Weisbecker <>
Cc: Ingo Molnar <>
Signed-off-by: default avatarJoel Fernandes <>
Signed-off-by: default avatarSteven Rostedt <>
parent be54f69c
......@@ -338,6 +338,13 @@ int trace_graph_entry(struct ftrace_graph_ent *trace)
if (ftrace_graph_notrace_addr(trace->func))
return 1;
* Stop here if tracing_threshold is set. We only write function return
* events to the ring buffer.
if (tracing_thresh)
return 1;
cpu = raw_smp_processor_id();
data = per_cpu_ptr(tr->, cpu);
......@@ -355,14 +362,6 @@ int trace_graph_entry(struct ftrace_graph_ent *trace)
return ret;
static int trace_graph_thresh_entry(struct ftrace_graph_ent *trace)
if (tracing_thresh)
return 1;
return trace_graph_entry(trace);
static void
__trace_graph_function(struct trace_array *tr,
unsigned long ip, unsigned long flags, int pc)
......@@ -457,7 +456,7 @@ static int graph_trace_init(struct trace_array *tr)
if (tracing_thresh)
ret = register_ftrace_graph(&trace_graph_thresh_return,
ret = register_ftrace_graph(&trace_graph_return,
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment