Commit a9febd66 authored by Paul E. McKenney's avatar Paul E. McKenney Committed by Greg Kroah-Hartman

locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath()

commit 548095de upstream.

Queued spinlocks are not used by DEC Alpha, and furthermore operations
such as READ_ONCE() and release/relaxed RMW atomics are being changed
to imply smp_read_barrier_depends().  This commit therefore removes the
now-redundant smp_read_barrier_depends() from queued_spin_lock_slowpath(),
and adjusts the comments accordingly.
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f02ef68b
...@@ -170,7 +170,7 @@ static __always_inline void clear_pending_set_locked(struct qspinlock *lock) ...@@ -170,7 +170,7 @@ static __always_inline void clear_pending_set_locked(struct qspinlock *lock)
* @tail : The new queue tail code word * @tail : The new queue tail code word
* Return: The previous queue tail code word * Return: The previous queue tail code word
* *
* xchg(lock, tail) * xchg(lock, tail), which heads an address dependency
* *
* p,*,* -> n,*,* ; prev = xchg(lock, node) * p,*,* -> n,*,* ; prev = xchg(lock, node)
*/ */
...@@ -417,13 +417,11 @@ void queued_spin_lock_slowpath(struct qspinlock *lock, u32 val) ...@@ -417,13 +417,11 @@ void queued_spin_lock_slowpath(struct qspinlock *lock, u32 val)
if (old & _Q_TAIL_MASK) { if (old & _Q_TAIL_MASK) {
prev = decode_tail(old); prev = decode_tail(old);
/* /*
* The above xchg_tail() is also a load of @lock which generates, * The above xchg_tail() is also a load of @lock which
* through decode_tail(), a pointer. * generates, through decode_tail(), a pointer. The address
* * dependency matches the RELEASE of xchg_tail() such that
* The address dependency matches the RELEASE of xchg_tail() * the subsequent access to @prev happens after.
* such that the access to @prev must happen after.
*/ */
smp_read_barrier_depends();
WRITE_ONCE(prev->next, node); WRITE_ONCE(prev->next, node);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment