Commit c877818a authored by Roman Penyaev's avatar Roman Penyaev Committed by Greg Kroah-Hartman

mm/vmalloc: fix size check for remap_vmalloc_range_partial()

commit 401592d2e095947344e10ec0623adbcd58934dd4 upstream.

When VM_NO_GUARD is not set area->size includes adjacent guard page,
thus for correct size checking get_vm_area_size() should be used, but
not area->size.

This fixes possible kernel oops when userspace tries to mmap an area on
1 page bigger than was allocated by vmalloc_user() call: the size check
inside remap_vmalloc_range_partial() accounts non-existing guard page
also, so check successfully passes but vmalloc_to_page() returns NULL
(guard page does not physically exist).

The following code pattern example should trigger an oops:

  static int oops_mmap(struct file *file, struct vm_area_struct *vma)
        void *mem;

        mem = vmalloc_user(4096);
        /* Do not care about mem leak */

        return remap_vmalloc_range(vma, mem, 0);

And userspace simply mmaps size + PAGE_SIZE:


Possible candidates for oops which do not have any explicit size

   *** drivers/media/usb/stkwebcam/stk-webcam.c:
   v4l_stk_mmap[789]   ret = remap_vmalloc_range(vma, sbuf->buffer, 0);

Or the following one:

   *** drivers/video/fbdev/core/fbmem.c
   static int
   fb_mmap(struct file *file, struct vm_area_struct * vma)
        res = fb->fb_mmap(info, vma);

Where fb_mmap callback calls remap_vmalloc_range() directly without any
explicit checks:

   *** drivers/video/fbdev/vfb.c
   static int vfb_mmap(struct fb_info *info,
             struct vm_area_struct *vma)
       return remap_vmalloc_range(vma, (void *)info->fix.smem_start, vma->vm_pgoff);

Link: default avatarRoman Penyaev <>
Acked-by: default avatarMichal Hocko <>
Cc: Andrey Ryabinin <>
Cc: Joe Perches <>
Cc: "Luis R. Rodriguez" <>
Cc: <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent c02fd076
......@@ -2262,7 +2262,7 @@ int remap_vmalloc_range_partial(struct vm_area_struct *vma, unsigned long uaddr,
if (!(area->flags & VM_USERMAP))
return -EINVAL;
if (kaddr + size > area->addr + area->size)
if (kaddr + size > area->addr + get_vm_area_size(area))
return -EINVAL;
do {
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment