Commit d1a265da authored by Shan Hai's avatar Shan Hai Committed by Greg Kroah-Hartman

bcache: release dc->writeback_lock properly in bch_writeback_thread()

commit 3943b040 upstream.

The writeback thread would exit with a lock held when the cache device
is detached via sysfs interface, fix it by releasing the held lock
before exiting the while-loop.

Fixes: fadd94e0 (bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set)
Signed-off-by: default avatarShan Hai <>
Signed-off-by: default avatarColy Li <>
Tested-by: default avatarShenghui Wang <>
Cc: #4.17+
Signed-off-by: default avatarJens Axboe <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent c8d875b4
......@@ -456,8 +456,10 @@ static int bch_writeback_thread(void *arg)
* data on cache. BCACHE_DEV_DETACHING flag is set in
* bch_cached_dev_detach().
if (test_bit(BCACHE_DEV_DETACHING, &dc->disk.flags))
if (test_bit(BCACHE_DEV_DETACHING, &dc->disk.flags)) {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment