Commit ec13c53d authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

pnfs/blocklayout: off by one in bl_map_stripe()

commit 0914bb96 upstream.

"dev->nr_children" is the number of children which were parsed
successfully in bl_parse_stripe().  It could be all of them and then, in
that case, it is equal to v->stripe.volumes_count.  Either way, the >
should be >= so that we don't go beyond the end of what we're supposed

Fixes: 5c83746a ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing")
Signed-off-by: default avatarDan Carpenter <>
Reviewed-by: default avatarChristoph Hellwig <>
Cc: # 3.17+
Signed-off-by: default avatarAnna Schumaker <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent ed480f2b
......@@ -204,7 +204,7 @@ static bool bl_map_stripe(struct pnfs_block_dev *dev, u64 offset,
chunk = div_u64(offset, dev->chunk_size);
div_u64_rem(chunk, dev->nr_children, &chunk_idx);
if (chunk_idx > dev->nr_children) {
if (chunk_idx >= dev->nr_children) {
dprintk("%s: invalid chunk idx %d (%lld/%lld)\n",
__func__, chunk_idx, offset, dev->chunk_size);
/* error, should not happen */
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment