1. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
         lines).
      
      All documentation files were explicitly excluded.
      
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
      
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
      
         For non */uapi/* files that summary was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0                                              11139
      
         and resulted in the first patch in this series.
      
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0 WITH Linux-syscall-note                        930
      
         and resulted in the second patch in this series.
      
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|------
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
      
         and that resulted in the third patch in this series.
      
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
      
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
      
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
      
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
      
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
  2. 14 May, 2017 1 commit
    • Kamil Rytarowski's avatar
      scripts: Switch to more portable Perl shebang · cb77f0d6
      Kamil Rytarowski authored
      The default NetBSD package manager is pkgsrc and it installs Perl
      along other third party programs under custom and configurable prefix.
      The default prefix for binary prebuilt packages is /usr/pkg, and the
      Perl executable lands in /usr/pkg/bin/perl.
      
      This change switches "/usr/bin/perl" to "/usr/bin/env perl" as it's
      the most portable solution that should work for almost everybody.
      Perl's executable is detected automatically.
      
      This change switches -w option passed to the executable with more
      modern "use warnings;" approach. There is no functional change to the
      default behavior.
      
      While there, drop "require 5" from scripts/namespace.pl (Perl from 1994?).
      Signed-off-by: default avatarKamil Rytarowski <n54@gmx.com>
      Signed-off-by: Masahiro Yamada's avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      cb77f0d6
  3. 24 May, 2016 1 commit
    • Arnd Bergmann's avatar
      headers_check: don't warn about c++ guards · 92181d47
      Arnd Bergmann authored
      A recent addition to the DRM tree for 4.7 added 'extern "C"' guards
      for c++ to all the DRM headers, and that now causes warnings
      in 'make headers_check':
      
      usr/include/drm/amdgpu_drm.h:38: userspace cannot reference function or variable defined in the kernel
      usr/include/drm/drm.h:63: userspace cannot reference function or variable defined in the kernel
      usr/include/drm/drm.h:699: userspace cannot reference function or variable defined in the kernel
      usr/include/drm/drm_fourcc.h:30: userspace cannot reference function or variable defined in the kernel
      usr/include/drm/drm_mode.h:33: userspace cannot reference function or variable defined in the kernel
      usr/include/drm/drm_sarea.h:38: userspace cannot reference function or variable defined in the kernel
      usr/include/drm/exynos_drm.h:21: userspace cannot reference function or variable defined in the kernel
      usr/include/drm/i810_drm.h:7: userspace cannot reference function or variable defined in the kernel
      
      This changes the headers_check.pl script to not warn about this.
      I'm listing the merge commit as introducing the problem, because
      there are several patches in this branch that each do this for
      one file.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Fixes: 7c10ddf8 ("Merge branch 'drm-uapi-extern-c-fixes' of https://github.com/evelikov/linux into drm-next")
      Reviewed-by: default avatarEmil Velikov <emil.l.velikov@gmail.com>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      92181d47
  4. 20 Aug, 2014 1 commit
  5. 24 Jan, 2014 1 commit
    • Paul Bolle's avatar
      headers_check: special case seqbuf_dump() · a7e1d98f
      Paul Bolle authored
      "make headers_check" warns about soundcard.h for (at least) five years
      now:
          [...]/usr/include/linux/soundcard.h:1054: userspace cannot reference function or variable defined in the kernel
      
      We're apparently stuck with providing OSSlib-3.8 compatibility, so let's
      special case this declaration just to silence it.
      
      Notes:
      
      0) Support for OSSlib post 3.8 was already removed in commit 43a99076
         ("sound: Remove OSSlib stuff from linux/soundcard.h").  Five years have
         passed since that commit: do people still care about OSSlib-3.8?  If
         not, quite a bit of code could be remove from soundcard.h (and probably
         ultrasound.h).
      
      2) By the way, what is actually meant by:
          It is no longer possible to actually link against OSSlib with this
          header, but we still provide these macros for programs using them.
      
      Doesn't that mean compatibility to OSSlib isn't even useful?
      
      3) Anyhow, a previous discussion soundcard.h, which led to that commit,
         starts at https://lkml.org/lkml/2009/1/20/349 .
      
      4) And, yes, I sneaked in a whitespace fix.
      Signed-off-by: default avatarPaul Bolle <pebolle@tiscali.nl>
      Cc: Takashi Iwai <tiwai@suse.de>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Cc: Michal Marek <mmarek@suse.cz>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a7e1d98f
  6. 26 Mar, 2012 1 commit
  7. 14 Dec, 2010 2 commits
  8. 07 Mar, 2010 1 commit
  9. 09 Jun, 2009 2 commits
  10. 30 Jan, 2009 1 commit
  11. 02 Jan, 2009 4 commits
  12. 29 Oct, 2008 1 commit
  13. 25 Jul, 2008 1 commit
    • Sam Ravnborg's avatar
      kbuild: optimize headers_* targets · 7712401a
      Sam Ravnborg authored
      Move the core functionality of headers_install
      and headers_check to two small perl scripts.
      The makefile is adapted to use the perl scrip and
      changed to operate on all files in a directory.
      So if one file is changed then all files in the
      directory is processed.
      
      perl were chosen for the helper scripts because this
      is pure text processing which perl is good at and
      especially the headers_check.pl script are expected to
      see changes / new checks implmented.
      
      The speed is ~300% faster on this box.
      And the output generated to the screen is now down to
      two lines per directory (one for install, one for check)
      so it is easier to scroll back after a kernel build.
      
      The perl scripts has been brought to sanity by patient
      feedback from: Vegard Nossum <vegard.nossum@gmail.com>
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      7712401a