• Nathan Chancellor's avatar
    ARM: 8833/1: Ensure that NEON code always compiles with Clang · 416b593a
    Nathan Chancellor authored
    [ Upstream commit de9c0d49d85dc563549972edc5589d195cd5e859 ]
    While building arm32 allyesconfig, I ran into the following errors:
      arch/arm/lib/xor-neon.c:17:2: error: You should compile this file with
      '-mfloat-abi=softfp -mfpu=neon'
      In file included from lib/raid6/neon1.c:27:
      error: "NEON support not enabled"
    Building V=1 showed NEON_FLAGS getting passed along to Clang but
    __ARM_NEON__ was not getting defined. Ultimately, it boils down to Clang
    only defining __ARM_NEON__ when targeting armv7, rather than armv6k,
    which is the '-march' value for allyesconfig.
    >From lib/Basic/Targets/ARM.cpp in the Clang source:
      // This only gets set when Neon instructions are actually available, unlike
      // the VFP define, hence the soft float and arch check. This is subtly
      // different from gcc, we follow the intent which was that it should be set
      // when Neon instructions are actually available.
      if ((FPU & NeonFPU) && !SoftFloat && ArchVersion >= 7) {
        Builder.defineMacro("__ARM_NEON", "1");
        // current AArch32 NEON implementations do not support double-precision
        // floating-point even when it is present in VFP.
                            "0x" + Twine::utohexstr(HW_FP & ~HW_FP_DP));
    Ard Biesheuvel recommended explicitly adding '-march=armv7-a' at the
    beginning of the NEON_FLAGS definitions so that __ARM_NEON__ always gets
    definined by Clang. This doesn't functionally change anything because
    that code will only run where NEON is supported, which is implicitly
    Link: https://github.com/ClangBuiltLinux/linux/issues/287Suggested-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Acked-by: default avatarNicolas Pitre <nico@linaro.org>
    Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Reviewed-by: default avatarStefan Agner <stefan@agner.ch>
    Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
xor-neon.c 1.33 KB