Skip to content
  • Josh Poimboeuf's avatar
    x86/asm: Fix UNWIND_HINT_REGS macro for older binutils · af79ded4
    Josh Poimboeuf authored
    
    
    Apparently the binutils 2.20 assembler can't handle the '&&' operator in
    the UNWIND_HINT_REGS macro.  Rearrange the macro to do without it.
    
    This fixes the following error:
    
      arch/x86/entry/entry_64.S: Assembler messages:
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
      arch/x86/entry/entry_64.S:521: Error: non-constant expression in ".if" statement
    
    Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Fixes: 39358a03 ("objtool, x86: Add facility for asm code to provide unwind hints")
    Link: http://lkml.kernel.org/r/e2ad97c1ae49a484644b4aaa4dd3faa4d6d969b2.1502116651.git.jpoimboe@redhat.com
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    af79ded4