Commit 2ea1c197 authored by Eric Biggers's avatar Eric Biggers Committed by Greg Kroah-Hartman

drm/vgem: fix use-after-free when drm_gem_handle_create() fails

commit 21d2b122732318b48c10b7262e15595ce54511d3 upstream.

If drm_gem_handle_create() fails in vgem_gem_create(), then the
drm_vgem_gem_object is freed twice: once when the reference is dropped
by drm_gem_object_put_unlocked(), and again by __vgem_gem_destroy().

This was hit by syzkaller using fault injection.

Fix it by skipping the second free.

Fixes: af33a919 ("drm/vgem: Enable dmabuf import interfaces")
Reviewed-by: default avatarChris Wilson <>
Cc: Laura Abbott <>
Cc: Daniel Vetter <>
Signed-off-by: default avatarEric Biggers <>
Acked-by: default avatarLaura Abbott <>
Signed-off-by: default avatarRodrigo Siqueira <>
Link: Maxime Ripard's avatarMaxime Ripard <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 0d9ef3f5
......@@ -192,13 +192,9 @@ static struct drm_gem_object *vgem_gem_create(struct drm_device *dev,
ret = drm_gem_handle_create(file, &obj->base, handle);
if (ret)
goto err;
return ERR_PTR(ret);
return &obj->base;
return ERR_PTR(ret);
static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment