Commit 2f74717d authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

clk: mmp: Off by one in mmp_clk_add()

[ Upstream commit 2e85c57493e391b93445c1e0d530b36b95becc64 ]

The > comparison should be >= or we write one element beyond the end of
the unit->clk_table[] array.

(The unit->clk_table[] array is allocated in the mmp_clk_init() function
and it has unit->nr_clks elements).

Fixes: 4661fda1 ("clk: mmp: add basic support functions for DT support")
Signed-off-by: default avatarDan Carpenter <>
Signed-off-by: default avatarStephen Boyd <>
Signed-off-by: default avatarSasha Levin <>
parent d5f24323
......@@ -183,7 +183,7 @@ void mmp_clk_add(struct mmp_clk_unit *unit, unsigned int id,
pr_err("CLK %d has invalid pointer %p\n", id, clk);
if (id > unit->nr_clks) {
if (id >= unit->nr_clks) {
pr_err("CLK %d is invalid\n", id);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment