Commit 4f490894 authored by Kangjie Lu's avatar Kangjie Lu Committed by Greg Kroah-Hartman

tty: atmel_serial: fix a potential NULL pointer dereference

commit c85be041065c0be8bc48eda4c45e0319caf1d0e5 upstream.

In case dmaengine_prep_dma_cyclic fails, the fix returns a proper
error code to avoid NULL pointer dereference.
Signed-off-by: default avatarKangjie Lu <>
Fixes: 34df42f5 ("serial: at91: add rx dma support")
Acked-by: default avatarRichard Genoud <>
Cc: stable <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 2689a646
......@@ -1163,6 +1163,10 @@ static int atmel_prepare_rx_dma(struct uart_port *port)
if (!desc) {
dev_err(port->dev, "Preparing DMA cyclic failed\n");
goto chan_err;
desc->callback = atmel_complete_rx_dma;
desc->callback_param = port;
atmel_port->desc_rx = desc;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment